semuconsulting / PyGPSClient

Python Graphical GPS Client Application supporting NMEA, UBX, RTCM3, NTRIP & SPARTN Protocols
BSD 3-Clause "New" or "Revised" License
517 stars 103 forks source link

fix for IPV6 "Invalid Argument" error #98

Closed ahsanyusob closed 10 months ago

ahsanyusob commented 11 months ago

PyGPSClient Pull Request Template

Description

Minor change for IPv6 socket connection. "Invalid Argument" error is thrown even when a valid IPv6 address e.g. fe80::1%eth0 is given in server field.

Fixes # (issue)

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist:

semuadmin commented 11 months ago

@ahsanyusob Many thanks for this - appreciated. I'll review and get back to you asap (I may need to revise my understanding of the flowinfo and scopeid parameters - if there's no practical value in making them user-entry fields, it may be better to remove them from the GUI altogether)

semuadmin commented 10 months ago

will be incorporated into RC 1.4.6 #100