search

sensebox / sensebox-sketches

Microservice for compiling senseBox Wifi and Ethernet sketches
MIT License
0 stars 2 forks source link

Add sensebox esp32s2 #105

Closed mariopesch closed 5 months ago

mariopesch commented 9 months ago
mariopesch commented 9 months ago

@felixerdy do you have any idea why the test is failing?

mpfeil commented 7 months ago

@mariopesch

Test should reject request with invalid board is failing because https://github.com/sensebox/sensebox-sketches/blob/add-sensebox-esp32s2/test/test.js#L125C11-L125C124 is not equal to the response by the server. The server response is: Invalid board parameter. Valid values are: sensebox-mcu,sensebox,sensebox-esp32s2 In order to fix this you have to add sensebox-esp32s2 to the test case.

Test should download sketch for senseBox MCU-S2 ESP32S2 is failing because passed board has a typo sensebox_esp32s2 vs sensebox-esp32s2 https://github.com/sensebox/sensebox-sketches/blob/add-sensebox-esp32s2/src/builder.js#L10

mpfeil commented 7 months ago

@mariopesch LGTM. You can merge it.