search

sentinel-energy / friendly_data

Data format to interoperate between models and frameworks
https://sentinel-energy.github.io/friendly_data/
Apache License 2.0
12 stars 2 forks source link

Remove _ensure_posix #25

Closed olejandro closed 2 years ago

olejandro commented 2 years ago

_ensure_posix causes dpkg.read_pkg() to fail on datapackages with inline data. Based on https://github.com/frictionlessdata/frictionless-py/issues/590, the issue for which _ensure_posix was introduced in the first place appears to be fixed.

suvayu commented 2 years ago

Hi @olejandro , sorry it took me so long to find the time.

There was a packaging issue that prevented the CI from running correctly. I fixed it and rebased your PR on top of them, as you can see _ensure_posix is necessary to support Windows. If you look at the test failure, you can see that paths are converted to Windows paths instead of POSIX paths, as the spec requires.

Unfortunately this is a deficiency of the upstream implementation (since before the refactor) making this workaround necessary, see frictionlessdata/datapackage-py#279

I'll try to find a proper fix, shouldn't be too difficult.