HW8 ready for grading - Githubissues

sepkamal commented 7 years ago

This one's a good one!

vibudh2209 commented 7 years ago

Hi kamal,

Great work with your app, its working great as well as looks great ( 😄 )

Few Comments:

I really liked your theme and loading process as well as overall look of the website, great job there.
You have done great deal of improvements in your design, maybe you could have added few other options for data manipulation (like after choosing a continent to further allow choosing country) or some other feature. I mean obviously you have covered more than the required points but more data manipulation options could be better.
One more thing is please from next time try explaining your added features in README file so that one don't have to go through every bit of Server and UI files.
Apart from these everything is actually really amazing so I can't suggest more.

Overall amazing app with great design and features!!! Keep the good work!!!

Cheers Vibudh

menglinzhou commented 7 years ago

Hi, @sepkamal ! I am very happy to review your assignment! Here are some comments from me and I hope they can be useful.

Your app is split into a ui.R file and a server.R file
Your app is deployed online on shinyapps.io, and it could work.
Add a README.MD file to your Shiny app folder in your course repository
You choose your own dataset other than BC Liquor and show me the source of your data.
The yellow loading screen is really cool, and the link you give is really helpful.
You separate the plot and the table into to subpart in your app, which make your app more neat.
It's really important to library all needed packages in both ui.R and server.R. I also have this problem too.
It will be better if you add some description of your features in you README file which can help us to get through of you App.

Overall, great work! Menglin

sepkamal / STAT545-hw-Kamal-Sepehr