Closed moonbuggy closed 1 year ago
@moonbuggy Hi, and thank you very much for this PR. Unfortunately I currently do not have the mental bandwidth to give this PR the attention and review it deserves, but I will be back at it sometime in the next week, probably. In any case, it is not forgotten. :)
@moonbuggy Thanks so much for your time helping out the project. I've neglected Magnetissimo but I'm in the middle of a large port over to Phoenix Livewire now.
This PR has a ton of great things and great ideas. I'm going pluck some of your recommended changes and put them into the livewire-rewrite
branch.
I had forgotten about this. I was happy having an excuse to play around in Elixir for a little while, but I'm glad some of the ideas were useful (even if the code itself isn't, in the new framework).
I'll have to have a look at your livewire rewrite when I get some free time and energy. I'm having my own mental bandwidth issues lately, various projects digressing in random directions.
(It's the usual story: you decide you want a PXE server for x64 cluster nodes and next thing you know you're patching buggy hardware PWM drivers and building kernels for poorly supported ARM devices so your PXE server can have a controllable fan. :))
I decided this might be a good project where I could spend a few days learning how to work Elixir a bit, and this is where I ended up. I'm not sure if it's of any interest to you, since you're now focused on Torrentinim, but I thought I'd send a PR along in case it was.
Here's what the PR does:
Magnetissimo.Crawler
,Magnetissimo.Parser
) for common code used in site configurationssize
tobigint
, allowing storage ofsize
in bytesmagnet_hash
column for potential future use in collationAs I have limited experience with Elixir I don't know if the code is particularly idiomatic, but it functions as expected. That's the important thing, I figure. :)