sergiotapia / magnetissimo

Web application that indexes all popular torrent sites, and saves it to the local database.
MIT License
2.98k stars 187 forks source link

Feature request: Use git tags to created tagged releases using Semantic Versioning #163

Closed loganmarchione closed 7 months ago

loganmarchione commented 1 year ago

Currently, there is only one tagged release of magnetissimo, which is 1.0-final from 2018.

I see that you recently setup GitHub Actions to publish container images to GHCR, which is great (no more building the app)! However, these images are built from master, so there is no way to tell what "version" of the app I'm running, or if an upgrade is a major, minor, or patch upgrade.

Ideally, you'd tag releases with a semantic version, like 1.2.3. This has a couple benefits:

You'd have to tweak the GitHub Action file to run on tags instead of pushes to master, and you'd also have to include the tag in the image name (like ghcr.io/sergiotapia/magnetissimo:1.2.3).

on:
  push:
    tags:
      - "[0-9]+.[0-9]+.[0-9]+"

You could still keep the master or latest tag that is built from master for users wanting to test.

sergiotapia commented 7 months ago

This is a wonderful idea, I would love to make this a reality! I'll add it to our Milestone list for Delicioso (3.0)

sergiotapia commented 7 months ago

That was pretty painless. We now build images on:

on:
  push:
    branches: 
      - master
      - delicioso
    tags:
      - "[0-9]+.[0-9]+.[0-9]+"