search

serpentine-h2020 / SEPpy

A compendium of Python data loaders and analysis tools for in-situ measurements of Solar Energetic Particles (SEP)
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Correctly implement option to define path where radio data files should be saved #27

Open jgieseler opened 1 year ago

jgieseler commented 1 year ago

Right now, when radio data is used in the dynamic_spectrum tool, the data is downloaded to the default path used by sunpy's fido. But the loading function actually already has the option to define a path included, it's just not used in the call from tools/__init.py__:

https://github.com/serpentine-h2020/SEPpy/blob/e9f4ecb2aa5a99a5b09db53de5a054d0d151edb6/seppy/tools/__init__.py#L97

https://github.com/serpentine-h2020/SEPpy/blob/e9f4ecb2aa5a99a5b09db53de5a054d0d151edb6/seppy/tools/swaves.py#L16-L35

Not completely sure if just Event.data_path should be used for it if defined, or if we should introduce another radio_data_path https://github.com/serpentine-h2020/SEPpy/blob/e9f4ecb2aa5a99a5b09db53de5a054d0d151edb6/seppy/tools/__init__.py#L37-L39