search

serpentine-h2020 / SEPpy

A compendium of Python data loaders and analysis tools for in-situ measurements of Solar Energetic Particles (SEP)
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Fix get_channel_energy_values for SOHO/EPHIN electrons #49

Closed jgieseler closed 7 months ago

jgieseler commented 11 months ago

get_channel_energy_values() is causing problems for SOHO/EPHIN electrons, before and after the change in data product on Oct 4, 2017. The return array has a length of 4 or 5, depending on time. But actually it should be be 3 or 4. The problems lie in https://github.com/serpentine-h2020/SEPpy/blob/2ff9cb844343d7f0d00cb248052ab78532c469d2/seppy/tools/__init__.py#L2270-L2274 and https://github.com/serpentine-h2020/SEPpy/blob/2ff9cb844343d7f0d00cb248052ab78532c469d2/seppy/tools/__init__.py#L2335-L2339 First, it's truncated wrongly. Second, after the change of the data product, one channel info changed to 'deactivated bc. of failure mode D', which cause that channel to be skipped in the second code example above.

jgieseler commented 8 months ago

Has this been fixed with https://github.com/jgieseler/SEPpy/commit/5d9eb6bae7c84e17255d37e8ec8de4b20388defa?

Christian-Palmroos commented 8 months ago

The pull request 52 (https://github.com/serpentine-h2020/SEPpy/pull/52) should address this.