search

serratus-bio / open-virome

monorepo for data explorer UI and APIs
http://openvirome.com/
GNU Affero General Public License v3.0
0 stars 0 forks source link

Geocoding on biosample attributes could be improved #86

Closed almosnow closed 2 weeks ago

almosnow commented 4 weeks ago

I was looking at several data points on the geo map and some of them are geocoded (text -> latlon) improperly.

It's not material but geocoding them with Google APIs yields much better results.

We had chose to use Amazon Location for this but I do see an improvement on switching to Google.

(Is there a way to use both and choose the best one?)

Leaving this here for future discussion.

almosnow commented 2 weeks ago

@ababaian Y/N?

ababaian commented 2 weeks ago

I'm leaning to no. The rate or measurement of improvement is undetermined, nor is there a measurement or benchmark to support this?

Any method is flawed and unless there's a good rationale and method to validate strings for this, it's a "nice to have" feature which is non-essential.