Lots of "got script tick after closure" when visiting various ML homepage sites and going back in history

servo / servo

Servo, the embeddable, independent, memory-safe, modular, parallel web rendering engine

https://servo.org

Mozilla Public License 2.0

28.45k stars 3.03k forks source link

Lots of "got script tick after closure" when visiting various ML homepage sites and going back in history #22746

Open jdm opened 5 years ago

jdm commented 5 years ago

I suspect the transparent rectangles page started some persistent rAF loop that didn't get cancelled.

asajeffrey commented 5 years ago

@jdm is this replicable on not-magicleap servo? It sounds like the rAF thread isn't responding to freeze properly.

jdm commented 5 years ago

I can reproduce this on desktop; if I load the transparent rects demo then load another page, I keep seeing the FPS counter in the terminal from console.log statements that happen in the previous page's rAF event.

jdm commented 5 years ago

This compositor code doesn't take into account whether a pipeline is frozen or not; neither does this constellation code. It would probably be best to avoid sending the message from the compositor if the necessary information is available at that point.