search

servo / servo

Servo, the embeddable, independent, memory-safe, modular, parallel web rendering engine
https://servo.org
Mozilla Public License 2.0
28.4k stars 3.03k forks source link

WPT tests expect MIME charset case-preservation #24874

Open pshaughn opened 4 years ago

pshaughn commented 4 years ago

Asssuming https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/fetch/api/basic/scheme-data.any.js is a correct test, MIME charsets need to roundtrip through response headers with their case intact. mime::Mime isn't enabling this as of now (I let them know at https://github.com/hyperium/mime/issues/116 ). Alternatives could be to store content types some other way, or to push back against WPT for doing a case-sensitive match on the Javascript string of something that, by RFC 7231, is semantically case-insensitive as a character set identifier.

pshaughn commented 4 years ago

irc.w3.org consensus was definitely that the test is right, and proactively case-folding a header value just because it has a case-insensitive function is wrong