search

servo / servo

Servo, the embeddable, independent, memory-safe, modular, parallel web rendering engine
https://servo.org
Mozilla Public License 2.0
28.37k stars 3.03k forks source link

Implement support for the `clip-path` rule #30514

Open EnnuiL opened 1 year ago

EnnuiL commented 1 year ago

I've spotted this issue at first while attempting to correct test expectations on PR #30439 (relevant comment: https://github.com/servo/servo/pull/30439#issuecomment-1744074473);

My first assumption was "oh well, maybe this is what I deserve for running this on the Intel Arc A380 while also on Linux", but well, looking at wpt.fyi results show that it might be a more widespread issue, with this comparison of clip-path-rect-001.html matching the ones I get: A cropped screenshot of a failing `clip-path-rect-001.html` test. The green box hasn't been clipped here

Attempting to use --software while using ./mach run didn't affect the outcome, and both --legacy-layout and --layout are affected

jdm commented 1 year ago

According to https://github.com/servo/servo/blob/master/tests/wpt/include.ini#L40C8-L42 we only run the tests under css-masking/clip in our CI right now.

jdm commented 1 year ago

However, running tests on directory like css-masking will run all tests underneath it, ignoring the configuration from that linked file.

EnnuiL commented 1 year ago

Oh well, I should have paid more attention to what exactly was failing; It turns out clip-path isn't implemented at all; I'll update the issue name in order to reflect that; (maybe I could implement something...? who knows, I don't know! :p)