Bad timestamp when prepare trace

sfhardman / kong-plugin-zipkin

Kong plugin to simulate clients and/or servers where these cannot practically be instrumented directly

Apache License 2.0

31 stars 9 forks source link

Bad timestamp when prepare trace #2

Closed dvdfib closed 6 years ago

dvdfib commented 7 years ago

https://github.com/sfhardman/kong-plugin-zipkin/blob/636f546e6d1266da418a8d66d246f4acc063e756/kong/plugins/zipkin/zipkin.lua#L106

The value of property timestamp in variable formatted_trace would be the value of start_time because get problems for display bars of nested span when plugin is configured with sample_once_every_n_requests=1 and simulate_server=false.

sfhardman commented 6 years ago

Thanks for spotting that