search

shamansir / rpd

:ok_hand: A Minimal Engine for creating Node-Based Visual Programming User Interfaces
http://shamansir.github.io/rpd
443 stars 48 forks source link

Value Displays and Editors should always have and receive parent container instead of injecting the editor into the HTML #436

Open shamansir opened 7 years ago

shamansir commented 7 years ago

From #417 and #434

shamansir commented 7 years ago

It is resolved for SVG styles, but fails for most of the HTML styles, so probably it should be fixed in the styles, not in the renderer (since they create the HTML element to hold the value).

shamansir commented 7 years ago

No, the problem is actually different:

  • There's always a .value-holder for inlets, a wrapper for a .value, since they need a parent element where editor needs to be injected;
  • There's no .value-holder for outlets, since they need no editor;
  • channelrenderer.show should work for both cases;
  • Channel Renderers currently inject value directly into the element using innerHtml for both cases;