search

sharpie7 / circuitjs1

Electronic Circuit Simulator in the Browser
GNU General Public License v2.0
2.29k stars 633 forks source link

Feature- re-edit user defined component #577

Closed TimFFischer closed 2 years ago

TimFFischer commented 3 years ago

I have trouble to re-edit user defined components. Right clicking and "edit..." only enables to select a model and edit its appearance. It would be great to have a way to change the inner cicruit. Something like a text input/output box (like export as text) would also be fine.

pfalstad commented 3 years ago

that would be hard because we don't save the original layout. we save the circuit in a compiled form. we could save the original layout but then the user defined components would be much bigger when saved. maybe we could do it optionally.

TimFFischer commented 2 years ago

looks good! Is there a posibility to come back from the subcircuit to the upper-level circuit?

pfalstad commented 2 years ago

Undo? 😊

ormaaj commented 2 years ago

Works. Even sub-subcircuits unpack and preserve layout. Nice! (Exponential backslash escaping per level!)

Yeah many tools have a push/pop circuit stack thing but I see the saves persist through undos. Good nuff.

TimFFischer commented 2 years ago

Works. But I thought that there is a way to open-> change->save a subcircuit without a new creation of a subcircuit.

For me the present solution solves my problems.