sharpie7 / circuitjs1

Electronic Circuit Simulator in the Browser
GNU General Public License v2.0
2.35k stars 642 forks source link

Translation submit (Taiwan Chinese) #603

Closed dcadc closed 3 years ago

dcadc commented 3 years ago

Hi, I would like to contribute the translation of Mandarin (Chinese) in Taiwan. locale_zhtw.txt

It was hard to setup the GWT compiler to verify my translation, so I just translated using locale_zh.txt, but found out there are still something not translated on the online demonstration. I was wondering if there is a full translation template somewhere, thanks!

pfalstad commented 3 years ago

Thank you! You can see it here: http://www.falstad.com/circuit/circuitjs.html?lang=zhtw

Here is a list of missing strings.

missing_zhtw.txt

dcadc commented 3 years ago

Newer version with missing strings translated.

locale_zhtw.txt

dcadc commented 3 years ago

Latest fixed version.

locale_zhtw.txt

pfalstad commented 3 years ago

I have updated my site. You may have to clear your cache.

What should I use as the language name, for the language chooser in the other options dialog?

dcadc commented 3 years ago

If we are just adding a new language option, it should be '中文 (台灣)'

But to be more inclusive (for potential future translations), I suggest we rename '中文' to '中文 (中国大陆)' to be distinct from zh-tw. That suggestion is based on the de facto translation used on Wikipedia.

Also if the system is able to support language codes with hyphen, you can rename it into locale_zh-tw.txt

BTW, here is a newer version of translation locale_zhtw.txt, Thx

pfalstad commented 3 years ago

This is traditional Chinese, yes? Would this also be the best choice for Singapore?

pfalstad commented 3 years ago

Never mind, I see that it wouldn't

pfalstad commented 3 years ago

The code doesn't support language codes with a hyphen currently.. I will add a special case for Taiwan

pfalstad commented 3 years ago

Oops that list of missing strings I sent was not up to date. Here is the up to date list.

"RUN / Stop" "Can't load canvas2svg.js." "Copy to Clipboard" "Download last played audio" "File name:"

dcadc commented 3 years ago

Yes, this is Traditional Chinese, it might look similar to zh-hk (Hong Kong) and zh-mo (Macao), but there are still a lot of differences in terminologies. As far as I know, Singaporean and Malaysian use Simplified Chinese instead of this.

Everything looks great, I think this will be the final version of translation file. locale_zhtw.txt

pfalstad commented 3 years ago

Thanks, updated