sharpie7 / circuitjs1

Electronic Circuit Simulator in the Browser
GNU General Public License v2.0
2.29k stars 633 forks source link

Incorrect initialization of VCVS element #625

Closed Vort closed 3 years ago

Vort commented 3 years ago

When VCVS is created, exprString is set to 2*(a-b): https://github.com/sharpie7/circuitjs1/blob/17dae55d592b03cefbbadf68f73583645ccc9217/src/com/lushprojects/circuitjs1/client/VCVSElm.java#L33 But it is not applied correctly because of this line: https://github.com/sharpie7/circuitjs1/blob/17dae55d592b03cefbbadf68f73583645ccc9217/src/com/lushprojects/circuitjs1/client/VCCSElm.java#L40 So actually VCVS applies function .1*(a-b) instead of 2*(a-b) until user changes it to something else.

Vort commented 3 years ago

Fixed. Thank you.