sharpie7 / circuitjs1

Electronic Circuit Simulator in the Browser
GNU General Public License v2.0
2.29k stars 633 forks source link

"Add Sliders" duty cycle default max should be 100 (not 1000) and phase offset default max should be 360 (not 1000) #681

Closed ericfont closed 2 years ago

ericfont commented 2 years ago

When create a voltage or current source and use a waveform like square wave, and then right click it and click "Sliders" and check the boxes for "Phase offset (degrees)" and "Duty Cycle", the form populates both of those max values at 1000 by default:

image

But these are not useful or reasonable default max values. More useful and reasonable default max values would be 100 for duty cycle (cause duty cycle can only run from 0% to 100%) and 360 for Phase offset (cause degrees go from 0 to 360 around a circle).

pfalstad commented 2 years ago

this is #312

ericfont commented 2 years ago

oh yes, sorry for the duplicate issue.

pfalstad commented 2 years ago

fixed