search

sharpie7 / circuitjs1

Electronic Circuit Simulator in the Browser
GNU General Public License v2.0
2.29k stars 633 forks source link

Bug - Creating subcircuits -- Errormessage "Some nodes are unconnected!" #751

Closed Jara-da-Cimrman closed 2 years ago

Jara-da-Cimrman commented 2 years ago

There is a problem of creating more complex subcircuits (eg O.A. 339, 741, 431, 317, 723 ...) in the last few versions. You always get the error message "Some nodes are unconnected!" In online version 2.4.2, these subcircuits can be created without any problems. I can provide schematics of these circuits to verify the problem.

pfalstad commented 2 years ago

hi, could you give me an example?

Jara-da-Cimrman commented 2 years ago

Hi, sorry for the lagging some schematics are in the annex in the latest version, an error message is displayed when creating the subcircuit in the online version 2.4.2 (https://lushprojects.com/circuitjs/circuitjs.html) creation the same subcircuit is functional

MAA723.txt LM386.txt LM723.txt

pfalstad commented 2 years ago

ok this was broken by the fix for #581. To fix that, we check for any nodes that are not connected to ground, and complain if we find any. But in these circuits, nothing is connected to ground.

Jara-da-Cimrman commented 2 years ago

Hi, perhaps another useful note: not all relatively complicated circuits cause this error. (attached) The error also sometimes does not occure if you randomly select only a part of the problematic circuit with at least some valid nodes. (Tested on the circuit MAA741).

LM339.txt TL431.txt