search

sharpie7 / circuitjs1

Electronic Circuit Simulator in the Browser
GNU General Public License v2.0
2.35k stars 642 forks source link

Add query parameter option "euroGates" #796

Closed johndoe31415 closed 2 years ago

johndoe31415 commented 2 years ago

Currently, IEC gates are by default selected when a German locale is detected. This patch introduces a query parameter "euroGates" which overrides the default locale setting if specified so that it is possible to display ANSI gates by default even on a browser with German locale.

pfalstad commented 2 years ago

Hi, thanks, but I did this already. This was #655 . Only I called it IECGates.

You should fork from https://github.com/pfalstad/circuitjs1 not sharpie7's tree. His is way behind mine.

johndoe31415 commented 2 years ago

Dang, thanks for the hint! Will do. I also saw that in your version the editing/selecting colors are editable, but not via query parameters. I might submit a PR for that as well if it has any chance to make it in there.

EDIT: You also fixed that:

        selectColor = qp.getValue("selectColor");
        currentColor = qp.getValue("currentColor");

But I don't think it's documented yet. Maybe a PR for that then ;-)