sharpie7 / circuitjs1

Electronic Circuit Simulator in the Browser
GNU General Public License v2.0
2.23k stars 622 forks source link

Subcircuit Error Message Text Locking Glitch #852

Open Danielboy12345 opened 1 year ago

Danielboy12345 commented 1 year ago

This only occurs on the Standalone-Offline addition.

When using the "Create Subcircuit" feature under File and there is an error present with the subcricuit, such as a disconnected node or no labeled nodes, the error message pops up as usual. After you close it, however, none of the shortcut keys work anymore nor can you change any parameters of placed components. Whenever you go to edit the components, clicking on the textbox does not make the "|" symbol appear nor does the box get highlighted. You can select the parameters with a cursor drag and delete them, but you cannot type at all. I think it may have something to do with the error message popup, but I am unsure.

While typing this, I discovered a fix. By clicking out of the standalone window and back into it, it restores the ability to use shortcuts and to type in parameters. The error message popup is most likely not properly refocusing the window, causing problems with the popups of the components.

pfalstad commented 1 year ago

Is this the offline version? This sounds like #596.

Danielboy12345 commented 1 year ago

It is the offline version.


From: Paul Falstad @.> Sent: Sunday, April 9, 2023 3:14:52 AM To: sharpie7/circuitjs1 @.> Cc: Unky Dan @.>; Author @.> Subject: Re: [sharpie7/circuitjs1] Subcircuit Error Message Text Locking Glitch (Issue #852)

Is this the offline version? This sounds like #596https://github.com/sharpie7/circuitjs1/issues/596.

— Reply to this email directly, view it on GitHubhttps://github.com/sharpie7/circuitjs1/issues/852#issuecomment-1501060344, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATCZEYXKVIYQR7S42SMPKZTXAJOWZANCNFSM6AAAAAAWEK2RN4. You are receiving this because you authored the thread.Message ID: @.***>