search

sharpie7 / circuitjs1

Electronic Circuit Simulator in the Browser
GNU General Public License v2.0
2.23k stars 619 forks source link

555 Timer's reset pin is active low, so should have bar over name #924

Open ericfont opened 5 months ago

ericfont commented 5 months ago

Active low pins typically use a naming convention that puts a bar over the name. For the most part, datasheets and wikipedia.org/wiki/555_timer_IC have a bar over the reset pin name. Circuitjs already puts a bar over the 555's trigger pin, so the reset pin should also have a bar.

ericfont commented 5 months ago

Separate but related: I would also suggest that the pin currently named "Vin" should be renamed to "Vcc" as per typical naming of voltage supply pins and usage in 555 datasheets and 555's wikipedia page currently. "Vin" is also a little ambiguous (cause all 555 pins except the output and discharge could hypothetically be considered to be input pins). I didn't put it in this PR to keep this PR simple, but I would just suggest you consider also replacing instances of the string "N_VIN" with "N_VCC" and the string "Vin" with "Vcc" in this file.