shedaniel / RoughlyEnoughItems

Clean and Configurable. Your recipe viewer mod for 1.13+.
Other
327 stars 66 forks source link

[Bug] Weird framerate lag #1396

Closed Abalieno closed 1 year ago

Abalieno commented 1 year ago

What happened?

I've been trying to troubleshoot this for a few hours. It's really something weird.

I started to notice that I was having some framerate lag when moving the mouse pointer across the item list, both favorites and standard one. I tried changing a number of internal settings on REI, but without success.

The problem is obviously more noticeable in larger modpacks, but I can measure it even on a small one.

The weird part: I noticed that I had some regular lag even if I left the mouse pointer hovering on one item (any item) without doing anything else. But there was zero lag instead if the item was in the inventory.

The image I attached shows the fps monitor in the background, while I leave the mouse over a random item. This is a regular hicckup, it keeps going that way. Sometimes it happens on both the item list and bookmarks, sometimes only on the item list. It never happens on inventory items.

But the weirdest part is that this lag goes completely away if I have a recipe open (any recipe). The graph always goes completely smooth.

While messing with settings I enabled "entry panel debug mode". Even this one confirms what I've seen: while hovering on any item on the right panel, I get a constant shift between 1500ns and 4000/5000, back and forth. If I hover on a inventory item, it's 1500/1800ns constant. And if I have a recipe open, then it also is perfectly constant.

What mod loaders are you seeing the problem on?

Fabric

What do you think this bug is of?

Relevant log output

This is a spark profile while I was having heavier performance issues, but nothing special sticks out. It's not important.
https://spark.lucko.me/sEyGPdevuz

Anything else?

ukuikuik

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.