shedaniel / RoughlyEnoughItems

Clean and Configurable. Your recipe viewer mod for 1.13+.
Other
327 stars 66 forks source link

[Bug] Move Items button (+) places ingredients on the wrong slots #1492

Closed p3lim closed 1 year ago

p3lim commented 1 year ago

What happened?

Happens with any recipe in a crafting table: image image

What mod loaders are you seeing the problem on?

Fabric

What do you think this bug is of?

Relevant log output

no log output

Anything else?

Version 9.1.650 (latest available on modrinth for 1.19.2)

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

Pootleris commented 1 year ago

same here porcodio

dPandl commented 1 year ago

This happens to me too

Authrec commented 1 year ago

I get this issue using REI 12.0.652, but downgrading to 12.0.648 the issue is no longer present.

IWaltherI commented 1 year ago

This problem also happened on version 1 18 2 forge. On the old version that I had for a long time - 8 3 6 42 - there is no such thing. And the thing is exactly in version 8 3 6 49 on 1 18 2, it was tested on assemblies and on a clean mine, where only the rei was and the library.

kingstairs commented 1 year ago

Confirming this with Fabric 1.19.2, any recipe. Release .650 updated the "Transfer API", which I believe is what places recipe components in the crafting table grid, that is most likely the source of the problem.

Fl414r commented 1 year ago

1.20.1 same

squid233 commented 1 year ago

Same in fabric 1.20.1 v12.0.652, with Lithium installed.

shedaniel commented 1 year ago

I cannot personally reproduce this issue, can someone send their logs here?

szernex commented 1 year ago

It seems that Lithium is the culprit. Tested on 1.19.2 Fabric version 0.14.22, REI 9.1.657, Lithium 0.11.1

I had only REI and Lithium (and any required libraries) installed. With Lithium disabled shift clicking on the + for recipes works just fine. As soon as I enabled Lithium it was messing up the recipes. I attached the logs for both cases.

with_lithium.zip without_lithium.zip

shedaniel commented 1 year ago

@szernex Thanks, I will test that right away

MDMCK10 commented 1 year ago

Can reproduce. Fabric 0.14.22 (1.20.2) Lithium 0.12.0 REI 13.0.661

shedaniel commented 1 year ago

This issue is with how Lithium changed the implementation of CompoundNBT, this is an unfortunate issue that I have now workaround with.