shedaniel / RoughlyEnoughItems

Clean and Configurable. Your recipe viewer mod for 1.13+.
Other
326 stars 65 forks source link

[Bug] REI Give/Grab functions not working #1599

Closed Gamemassa closed 6 months ago

Gamemassa commented 6 months ago

What happened?

When I click items in the REI window, REI does not add those items to my inventory. Also, when I set it to Grab mode instead, I try to drag items into my inventory and they do not go into the slots I try to put them in. Sometimes when I restart my game the items I had tried to add appear in my inventory.

What mod loaders are you seeing the problem on?

Fabric 1.20.4

What do you think this bug is of?

Relevant log output

Here is the latest.log:
https://gist.github.com/Gamemassa/54a1ad8814b6eb5fd515419876ee4b3d

This bug does not cause any crashes, so there is no crash report to attach.

Anything else?

No response

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

Gamemassa commented 6 months ago

Update: The Give issue and the Grab issue may be two separate issues. I loaded up a different instance of Fabric 1.20.4 with only REI and its prerequisites, and I set REI cheating mode to "Give" and it works, so I think in my primary instance there may be a conflict causing that (I'll do some debugging and narrow it down). When I set cheating mode to "Grab" and tried dragging items into my inventory, the items still would not be placed in my inventory, so I think that might be an issue within REI.

Gamemassa commented 6 months ago

Update: Turns out that updating Fabric API from 0.96.3 to 0.96.11 (the latest one available) fixed the issue with the Grab mode. Still working on the issue with the Give mode.

Gamemassa commented 6 months ago

Update: Ok, so the Give issue is definitely a mod conflict (of course). Gonna do some tinkering and try to isolate the conflict.

Gamemassa commented 6 months ago

I haven't isolated any conflicts in my modpack yet, but I found another bug that may be related to the Give issue. When I give myself an item using REI, and then destroy it using either REI or the Destroy Item box in Creative, it doesn't appear to be completely destroyed, because if I give myself the same item again, I suddenly have two of that item (and so on and so forth with subsequent attempts).

Update: ~No idea what, but something, just fixed the incomplete-deletion bug I just described. I'm doing a sort of binary test to filter a handful of mods at a time, and in the most recent group, the only mod that even sounds like it could've fixed that is Better Resource Runtime Pack (BRRP), so I assume that fixed it.~ Correction, this issue is still happening.

Gamemassa commented 6 months ago

Update: Not only have I isolated the conflict as being Inventorio, but I think the bug is mostly (if not completely) the fault of that mod. When I give myself an item from REI in Creative mode, the item doesn't pop up, but then when I switch to Survival or Adventure mode, the item I had tried to give pops in, and giving other items from REI works fine. I'm going to copy this error report over at the Inventorio GitHub and see what they say.

Update: Rubix (the dev of Inventorio) says this is definitely a bug, and they'll look into it on their end soon when they have time.

Gamemassa commented 6 months ago

Rubix figured out what the issue was (Inventorio was definitely causing it), and it's now fixed with the latest version of Inventorio.