[Bug] Favourites don't save after game restart

EnderDrag0n commented 5 months ago

What happened?

When i favorite recipe and after that restart game, favorites dissapear and i need to favorite them again

What mod loaders are you seeing the problem on?

Fabric

What do you think this bug is of?

[ ] Visual
[ ] Recipe Lookup
[ ] Cheat Mode
[ ] Plugin Integration / JEI Plugin Compatibility
[X] Others

Relevant log output

logs:https://gist.github.com/EnderDrag0n/c6a47a5d338a36b47e04e3d2d2a8764d

Anything else?

Minecraft version: 1.19.2 REI version: 9.2.724 Modpack Statech Industry

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

[X] Yes, and I did not use any paste services other than GitHub Gists.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

[X] Yes

EnderDrag0n commented 5 months ago

Seems like something is cleaning favorites.json5

ValokAsura commented 5 months ago

I just wanted to confirm this issue, and I noticed that favorites.json5 gets reset when loading into my single-player world.

On world exit and Minecraft exit, favorites.json5 still contains my favorites. While loading into the world, I use notepad++ to examine the file and spam refresh. Just before I'm able to take control, the file is reset to defaults.

I'm on MC 1.21 with REI v16.0.729+fabric

maciejstepie commented 4 months ago

I have the same issue, my favs disappear after game reloads

shedaniel / RoughlyEnoughItems