sherlock-audit / 2023-06-real-wagmi-judging

3 stars 2 forks source link

0xhacksmithh - Hardcoded `MINIUM_AMOUNT` Is Insigificant In Some Token Cases #188

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

0xhacksmithh

medium

Hardcoded MINIUM_AMOUNT Is Insigificant In Some Token Cases

Summary

refer Details section

Vulnerability Detail

MINIUM_AMOUNT is hardcoded with 1000_000

uint256 public constant MINIMUM_AMOUNT = 1000_000;

And protocol supports multiple tokens, like WBTC which have less Decimals 8 compair to other ERC20 token 18 and even some other tokens have less decimal but high in market price.

In that case this assumption will Insignificant.

Impact

refer Vulnerability Detail

Code Snippet

https://github.com/sherlock-audit/2023-06-real-wagmi/blob/main/concentrator/contracts/Multipool.sol#L74

Tool used

Manual Review

Recommendation

Consider this senario again

Duplicate of #90