sherlock-audit 2023-12-notional-update-5-judging issues

sherlock-audit / 2023-12-notional-update-5-judging

7 stars 7 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Create Sing_inssueSG.py

#67 Chicook closed 9 months ago
0
eol - Rebalancing triggers too often and causes losses in rewards due to precision loss

#66 sherlock-admin2 closed 10 months ago
4
eol - `ExternalLending` - executing redemptions for fee-on-transfer tokens from AaveV3 will always revert

#65 sherlock-admin2 opened 10 months ago
4
bin2chen - Immediate payment of REWARD_TOKEN may block most of nToken's operations

#64 sherlock-admin2 closed 10 months ago
2
lemonmon - Potential issues caused by the current implementation of the catch-block inside `wfCashERC4626._previewDeposit()`

#63 sherlock-admin2 closed 10 months ago
2
lemonmon - Necessary rebalance may not occur due to wrongly computed return value from `TreasuryAction._isExternalLendingUnhealthy()`

#62 sherlock-admin2 closed 10 months ago
0
MohammedRizwan - Use safeTransfer() instead of transfer()

#61 sherlock-admin2 closed 10 months ago
0
twicek - The `wfCashLogic.mintViaUnderlying` function does not calculate residual token balance correctly

#60 sherlock-admin2 closed 10 months ago
2
eol - `wfCashERC4626` - any residual ETH when lending at 0% interest is not refunded to the depositor

#59 sherlock-admin2 closed 10 months ago
1
eol - `wfCashERC4626` - Lending at 0% interest with a fee-on-transfer asset makes vault insolvent

#58 sherlock-admin2 opened 10 months ago
18
bin2chen - wfCash.sol unable to retrieve excess prime cash

#57 sherlock-admin2 closed 10 months ago
1
bitsurfer - Rounding issue on `previewMint` and `previewWithdraw`

#56 sherlock-admin2 closed 9 months ago
12
bin2chen - wfCashLogic.sol returned eth is locked in the contract

#55 sherlock-admin2 closed 10 months ago
1
bin2chen - mintViaUnderlying() minImpliedRate may be invalid

#54 sherlock-admin2 closed 10 months ago
1
eol - Incorrect storage gap in `wfCashBase` and `BaseERC4626Proxy` can lead to data corruption in storage when upgrading

#53 sherlock-admin2 closed 9 months ago
8
bin2chen - getTargetExternalLendingAmount() targetAmount may far less than the correct value

#52 sherlock-admin2 opened 10 months ago
3
bin2chen - getTargetExternalLendingAmount() when targetUtilization == 0 no check whether enough externalUnderlyingAvailableForWithdraw

#51 sherlock-admin2 opened 10 months ago
5
twicek - USDT cannot be retrieved using the `recover` function

#50 sherlock-admin2 closed 10 months ago
1
bin2chen - getOracleData() maxExternalDeposit not accurate

#49 sherlock-admin2 opened 10 months ago
3
xiaoming90 - Merkle root can be set before the detachment

#48 sherlock-admin2 closed 10 months ago
2
xiaoming90 - `lastRebalanceTimestampInSeconds` is not updated after rebalancing unhealthy external lending

#47 sherlock-admin2 closed 9 months ago
2
xiaoming90 - Rebalance might be skipped even if the external lending is unhealthy

#46 sherlock-admin2 opened 10 months ago
4
xiaoming90 - Does not approve to zero for USDT

#45 sherlock-admin2 closed 10 months ago
3
xiaoming90 - Rebalance will be delayed due to revert

#44 sherlock-admin2 opened 10 months ago
3
xiaoming90 - Unexpected behavior when calling certain ERC4626 functions

#43 sherlock-admin2 opened 10 months ago
4
xiaoming90 - Users can submit proof against non-existent merkle root

#42 sherlock-admin2 closed 10 months ago
2
xiaoming90 - `maxImpliedRate` is hardcoded to zero

#41 sherlock-admin2 closed 9 months ago
2
xiaoming90 - Potential division by zero during the minting of nToken

#40 sherlock-admin2 closed 10 months ago
2
xiaoming90 - Incorrect rate used when fCash has not settled yet

#39 sherlock-admin2 closed 10 months ago
1
xiaoming90 - External lending can exceed the threshold

#38 sherlock-admin2 opened 10 months ago
3
xiaoming90 - Malicious users can mint wfCash by using the wrapper's cash balance

#37 sherlock-admin2 closed 9 months ago
2
xiaoming90 - The use of spot data when discounting is subjected to manipulation

#36 sherlock-admin2 opened 10 months ago
7
xiaoming90 - Overlending of assets to external market

#35 sherlock-admin2 closed 9 months ago
2
xiaoming90 - `_previewDeposit` function returns max fCash when an error occurs

#34 sherlock-admin2 closed 9 months ago
3
xiaoming90 - Users can borrow beyond the debt cap

#33 sherlock-admin2 closed 9 months ago
2
xiaoming90 - Low precision is used when checking spot price deviation

#32 sherlock-admin2 opened 10 months ago
3
xiaoming90 - Cash in wrapper account can be drained due to rounding error

#31 sherlock-admin2 closed 9 months ago
2
xiaoming90 - Residual ETH not sent back when `batchBalanceAndTradeAction` executed

#30 sherlock-admin2 opened 10 months ago
5
xiaoming90 - Accumulated or earned pCash stuck in the wrapper contract

#29 sherlock-admin2 closed 9 months ago
5
xiaoming90 - Unable to limit the loss when redeeming wfCash before maturity

#28 sherlock-admin2 closed 9 months ago
5
xiaoming90 - Oracle supply rate is vulnerable to manipulation

#27 sherlock-admin2 closed 9 months ago
3
xiaoming90 - Rebalancing can lend beyond the debt cap

#26 sherlock-admin2 closed 9 months ago
4
xiaoming90 - Residual ETH will not be sent back to users during the minting of wfCash

#25 sherlock-admin2 opened 10 months ago
3
xiaoming90 - Rebalance is executed even if the change is less than 1%

#24 sherlock-admin2 closed 9 months ago
2
xiaoming90 - Loss of rewards if an update is triggered too close to the last update

#23 sherlock-admin2 closed 9 months ago
2
xiaoming90 - Malicious users could block liquidation or perform DOS

#22 sherlock-admin2 opened 10 months ago
5
tvdung94 - wfCashLogic::_sellfCash doesn't work correctly

#21 sherlock-admin2 closed 9 months ago
10
bin2chen - emissionRatePerYear invariant not match

#20 sherlock-admin2 closed 10 months ago
2
bin2chen - recover() using the standard transfer may not be able to retrieve some tokens

#19 sherlock-admin2 opened 10 months ago
12
bin2chen - _isExternalLendingUnhealthy() using stale factors

#18 sherlock-admin2 opened 10 months ago
16