sherlock-audit 2024-04-titles-judging issues

sherlock-audit / 2024-04-titles-judging

9 stars 6 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

sammy - `EDITION_MINTER_ROLE` is not configurable as `grantRoles()` cannot be called in `Edition.sol`

#213 sherlock-admin4 closed 4 months ago
12
brakeless - TitlesGraph::acknowledgeEdge() methods do not write acknowledgments to storage

#212 sherlock-admin3 opened 4 months ago
3
Yu3H0 - mint function will not refund any funds

#211 sherlock-admin4 closed 4 months ago
5
Yu3H0 - Misallocation in _splitProtocolFee function

#210 sherlock-admin3 closed 4 months ago
0
Yu3H0 - wrong usage of UUPSUpgradeable leads to non-upgradeable

#209 sherlock-admin4 closed 4 months ago
2
i3arba - Lack of Address Checks leads to multiple funcionalities breaking

#208 sherlock-admin3 closed 4 months ago
0
Bigsam - Potential Flaws in _refundExcess Function Leading to Overpayment and Gas Inefficiency

#207 sherlock-admin4 closed 4 months ago
0
sammy - `Edition.sol::mintBatch()` will always revert for `tokenIds_.length` greater than 1

#206 sherlock-admin3 closed 4 months ago
5
funkornaut - Users are not refunded extra eth

#205 sherlock-admin4 closed 4 months ago
10
Bigsam - Insufficient Validations in setTimeframe Function Leading to Invalid Timeframes

#204 sherlock-admin3 closed 4 months ago
0
Dots - User could mint multiple works for the price of one

#203 sherlock-admin4 closed 4 months ago
6
ydlee - `mintBatch` always reverts when minting for multiple works, breaking the core contract functionality.

#202 sherlock-admin3 closed 4 months ago
5
Squilliam - [M-1] Precision loss due to division before multiplication in `FeeManager._buildSharesAndTargets` (Incorrect Order of Operations)

#201 sherlock-admin4 closed 3 months ago
14
Bigsam - Vulnerability Report: Denial-of-Service Attack Risk Due to Inadequate Signature Verification in Contract

#200 sherlock-admin3 closed 4 months ago
5
AlexCzm - Users can `mintBatch` to mint out but pay for one token only

#199 sherlock-admin4 closed 4 months ago
5
Dots - Hardcoded ETH_ADDRESS could make problems on other blockchains

#198 sherlock-admin3 closed 4 months ago
1
0x73696d616f - `owner` of `FeeManager` is set to `TitlesCore`, which can not perform `onlyOwner` functions

#197 sherlock-admin4 closed 4 months ago
5
0x486776 - There are some useless functions in `Edition.sol`.

#196 sherlock-admin3 closed 4 months ago
1
0x486776 - No actual edition creation fee exists.

#195 sherlock-admin4 closed 4 months ago
0
durov - Incorrect `mintBatch()` logic lets users bypass paying most of the fees

#194 sherlock-admin3 closed 4 months ago
5
0x486776 - `FeeManager::_splitProtocolFee` doesn't send the `collectionReferrerShare` to the correct referrer.

#193 sherlock-admin4 closed 4 months ago
5
funkornaut - Mishandled ether in `Editions::mintBatch` allows tokens to be minted for free

#192 sherlock-admin3 closed 4 months ago
5
0x486776 - The remaining fee for creation is not sent to the creator of the edition.

#191 sherlock-admin4 closed 4 months ago
6
0x486776 - `Edition::_refundExcess` doesn't refund to the buyers.

#190 sherlock-admin3 closed 4 months ago
5
0x486776 - Reentrancy attack by edition referrer.

#189 sherlock-admin4 closed 4 months ago
5
0x486776 - `Edition::mintBatch` is always reverted.

#188 sherlock-admin3 closed 4 months ago
6
0x486776 - `Edition::mintBatch` receives less money than it should.

#187 sherlock-admin4 closed 4 months ago
5
cryptic - Excess ETH can be stolen since it is refunded from the incorrect contract

#186 sherlock-admin3 closed 4 months ago
8
kennedy1030 - The `Edition` contract's minting functions should be protected against reentrancy attacks.

#185 sherlock-admin4 closed 4 months ago
7
ydlee - Excess mint fees are not returned to the minter as expected.

#184 sherlock-admin3 closed 4 months ago
5
durov - Incorrect `_splitProtocolFee` logic leaves collection referrer with no collectionReferrerShare

#183 sherlock-admin4 closed 4 months ago
0
0x73696d616f - `TitlesGraph` is missing an `initialize()` function and is setting the `owner` and the `admin` in the constructor, having no `owner` or `admin` in the proxy

#182 sherlock-admin3 closed 4 months ago
5
AlexCzm - The edges will never be acknowledged because only memory copy is modified

#181 sherlock-admin4 closed 4 months ago
0
0x73696d616f - `TitlesGraph` upgradeability will not work as it is not deployed behind a proxy

#180 sherlock-admin3 closed 4 months ago
7
Squilliam - [H-2] Use of `msg.value` inside a loop in `Edition.sol` allows partial minting and unnecessary gas consumption (Incorrect Minting Fees + Gas Wastage + Partial Minting)

#179 sherlock-admin4 closed 4 months ago
0
0x73696d616f - `TitlesGraph::checkSignature()` modifier is vulnerable to signature malleability, allowing the manipulation of `edge.acknowledged`

#178 sherlock-admin3 closed 4 months ago
5
AlexCzm - CollectionReferrerShare is wrongly sent to mint referrer

#177 sherlock-admin4 closed 4 months ago
5
popeye - Incorrect Fee Distribution in `FeeManager.sol` Contract Affects Referrer Rewards

#176 sherlock-admin3 closed 4 months ago
5
0x73696d616f - Manipulated `edge.acknowledged` due to signature applying both to `TitlesGraph::acknowledgeEdge()` and `TitlesGraph::unacknowledgeEdge()`

#175 sherlock-admin4 closed 4 months ago
0
AlexCzm - Edition._refundExcess() doesn't refund the excess ether

#174 sherlock-admin3 closed 4 months ago
7
jecikpo - Not possible to assign EDITION_MINTER_ROLE in Edition

#173 sherlock-admin4 closed 4 months ago
1
0xboriskataa - Not all `EDITION_MANAGER_ROLE` functions can be called

#172 sherlock-admin3 closed 4 months ago
1
0x73696d616f - `TitlesGraph::checkSignature()` modifier does not implement EIP712 correctly as the `data` argument is not hashed in `ACK_TYPEHASH`

#171 sherlock-admin4 closed 4 months ago
0
fugazzi - TitlesGraph is incorrectly initialized, breaking upgradeability

#170 sherlock-admin3 closed 4 months ago
0
fugazzi - Edges cannot be acknowledged

#169 sherlock-admin4 closed 4 months ago
0
fugazzi - Signatures can be replayed by abusing signature malleability

#168 sherlock-admin3 closed 4 months ago
0
fugazzi - Invalid data encoding breaks EIP-712 compatibility

#167 sherlock-admin4 closed 4 months ago
0
fugazzi - Promo minter role cannot be assigned

#166 sherlock-admin3 closed 4 months ago
13
fugazzi - `mintBatch()` for multiple token ids is broken

#165 sherlock-admin4 closed 4 months ago
7
fugazzi - Edition minting is supposed to refund unused fees to caller but forwards all value to FeeManager

#164 sherlock-admin3 closed 4 months ago
5

Previous Next