sherlock-audit / 2024-08-cork-protocol-judging

2 stars 2 forks source link

Mammoth Laurel Nightingale - L-4 External Call Potential out of gas #286

Closed sherlock-admin3 closed 2 months ago

sherlock-admin3 commented 2 months ago

Mammoth Laurel Nightingale

Low/Info

L-4 External Call Potential out of gas

Location: [File name(s) and line numbers]

Description:

Olympix: Function name() calls external function name() at location /Depeg-swap/node_modules/@openzeppelin/contracts/token/ERC20/ERC20.sol L58:C4, which may cause execution to run out of gas.

Function swapExactTokensForTokens() calls external function swapExactTokensForTokens() at location /Depeg-swap/contracts/interfaces/uniswap-v2/RouterV1.sol L74:C4, which may cause execution to run out of gas.

Recommendation: Specify a gas budget for an external call that may exhaust a transaction's gas.

Impact: Detailed explanation of the potential consequences of this issue.

Recommendation: Recommendation: Specify a gas budget for an external call that may exhaust a transaction's gas.

siddhpurakaran commented 1 month ago

All those 3 are instances of internal contracts so they are reliable