search

sherlock-audit / 2024-08-cork-protocol-judging

2 stars 2 forks source link

Mammoth Laurel Nightingale - [I - 1] Modifier/Function/parameter/Variable is not in mixedCase #294

Closed sherlock-admin3 closed 2 months ago

sherlock-admin3 commented 2 months ago

Mammoth Laurel Nightingale

Low/Info

[I - 1] Modifier/Function/parameter/Variable is not in mixedCase

Summary

Vulnerability Detail

Modifier [ModuleState.LVDepositNotPaused(Id)](contracts/core/ModuleState.sol#L108-L113) is not in mixedCase
Function [VaultLibrary.__provideAmmLiquidityFromPool(State,IDsFlashSwapCore,address,IUniswapV2Router02)](contracts/libraries/VaultLib.sol#L174-L189) is not in mixedCase
Function [VaultLibrary.__provideLiquidityWithRatio(State,uint256,IDsFlashSwapCore,address,IUniswapV2Router02)](contracts/libraries/VaultLib.sol#L123-L137) is not in mixedCase
Parameter [DepegSwapLibrary.initialize(address,address,address)._address](contracts/libraries/DepegSwapLib.sol#L38) is not in mixedCase
Parameter [DepegSwapLibrary.initialize(address,address,address)._address](contracts/libraries/DepegSwapLib.sol#L38) is not in mixedCase
Variable [ExchangeRate.RATE](contracts/core/assets/Asset.sol#L17) is not in mixedCase
Function [VaultPoolLibrary.__tryRedeemfromWithdrawalPool(VaultPool,uint256)](contracts/libraries/VaultPoolLib.sol#L137-L145) is not in mixedCase
Function VaultPoolLibrary.__tryRedeemExcessFromAmmPool(VaultPool,uint256,uint256) (contracts/libraries/VaultPoolLib.sol#147-158) is not in mixedCase
Variable [ModuleState.AMM_FACTORY](contracts/core/ModuleState.sol#L24) is not in mixedCase
Function [VaultLibrary.__provideLiquidity(State,uint256,uint256,IDsFlashSwapCore,address,IUniswapV2Router02,uint256)](contracts/libraries/VaultLib.sol#L153-L172) is not in mixedCase
Modifier [ModuleState.LVWithdrawalNotPaused(Id)](contracts/core/ModuleState.sol#L115-L120) is not in mixedCase
Parameter [CorkConfig.setModuleCore(address)._moduleCore](contracts/core/CorkConfig.sol#L42) is not in mixedCase
Parameter RouterState.initialize(address,address)._univ2Router (contracts/core/flash-swaps/FlashSwapRouter.sol#32) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (contracts/interfaces/uniswap-v2/pair.sol#28) is not in mixedCase
Variable ModuleState.SWAP_ASSET_FACTORY (contracts/core/ModuleState.sol#21) is not in mixedCase
Function [VaultLibrary.__addLiquidityToAmmUnchecked(State,uint256,uint256,address,address,IUniswapV2Router02)](contracts/libraries/VaultLib.sol#L55-L79) is not in mixedCase
Function [IUniswapV2Pair.MINIMUM_LIQUIDITY()](contracts/interfaces/uniswap-v2/pair.sol#L47) is not in mixedCase
Variable ModuleState.CONFIG (contracts/core/ModuleState.sol#31) is not in mixedCase
Function VaultLibrary.__calculateTotalRaAndCtBalance(State,IDsFlashSwapCore,uint256) (contracts/libraries/VaultLib.sol#425-435) is not in mixedCase
Variable ModuleState.DS_FLASHSWAP_ROUTER (contracts/core/ModuleState.sol#26) is not in mixedCase
Function VaultPoolLibrary.__redeemfromWithdrawalPool(VaultPool,uint256) (contracts/libraries/VaultPoolLib.sol#126-135) is not in mixedCase
Function VaultLibrary.__calculateTotalRaAndCtBalanceWithReserve(State,uint256,uint256,uint256) (contracts/libraries/VaultLib.sol#450-470) is not in mixedCase
Function IUniswapV2Pair.DOMAIN_SEPARATOR() (contracts/interfaces/uniswap-v2/pair.sol#26) is not in mixedCase
Function RouterState.__flashSwap(AssetPair,IUniswapV2Pair,uint256,uint256,uint256,Id,bool,uint256) (contracts/core/flash-swaps/FlashSwapRouter.sol#316-336) is not in mixedCase
Function RouterState.__afterFlashswapBuy(ReserveState,Id,uint256,address,uint256) (contracts/core/flash-swaps/FlashSwapRouter.sol#357-378) is not in mixedCase
Function RouterState.__swapDsforRa(AssetPair,Id,uint256,uint256,uint256) (contracts/core/flash-swaps/FlashSwapRouter.sol#288-302) is not in mixedCase
Function VaultLibrary.__calculateCtBalanceWithRate(State,IDsFlashSwapCore,uint256) (contracts/libraries/VaultLib.sol#438-448) is not in mixedCase
Variable Expiry.TIMESTAMP (contracts/core/assets/Asset.sol#38) is not in mixedCase
Modifier ModuleState.PSMWithdrawalNotPaused(Id) (contracts/core/ModuleState.sol#101-106) is not in mixedCase
Parameter LvAssetLibrary.initialize(address)._address (contracts/libraries/LvAssetLib.sol#21) is not in mixedCase
Variable ModuleState.AMM_ROUTER (contracts/core/ModuleState.sol#29) is not in mixedCase
Function RouterState.__afterFlashswapSell(ReserveState,uint256,Id,uint256,address,uint256) (contracts/core/flash-swaps/FlashSwapRouter.sol#380-407) is not in mixedCase
Function VaultPoolLibrary.__decreaseUserAttributed(VaultPool,uint256,address) (contracts/libraries/VaultPoolLib.sol#68-70) is not in mixedCase
Modifier ModuleState.PSMDepositNotPaused(Id) (contracts/core/ModuleState.sol#87-92) is not in mixedCase
Function VaultPoolLibrary.__redeemExcessFromAmmPool(VaultPool,uint256,uint256) (contracts/libraries/VaultPoolLib.sol#160-168) is not in mixedCase
Function VaultLibrary.__getAmmCtPriceRatio(State,IDsFlashSwapCore,uint256) (contracts/libraries/VaultLib.sol#139-151) is not in mixedCase
Function VaultLibrary.__liquidateUnchecked(State,address,address,IUniswapV2Router02,IUniswapV2Pair,uint256) (contracts/libraries/VaultLib.sol#270-289) is not in mixedCase
Function IUniswapV2Router01.WETH() (contracts/interfaces/uniswap-v2/RouterV1.sol#6) is not in mixedCase

Impact

Severity: Informational Confidence: High

Code Snippet

Tool used

Manual Review

Recommendation

siddhpurakaran commented 1 month ago

Names of parameters/ functions / modifiers mentioned in this issue are correctly used casing as per Cork's development practices.

As this is not having any effect on flow, logic & behaviour of code so marking this as invalid issue and will not fix this