Mammoth Laurel Nightingale - [ L - 12 ] timestamp

[sherlock-admin2]

Mammoth Laurel Nightingale

Low/Info

[ L - 12 ] timestamp

Summary

VaultLibrary._liquidatedLp(State,uint256,IUniswapV2Router02,IDsFlashSwapCore) (contracts/libraries/VaultLib.sol#349-393) uses timestamp for comparisons Dangerous comparisons:

• ctAttributedToPa != 0 (contracts/libraries/VaultLib.sol#386)
• reservedDs >= ctAmm (contracts/libraries/VaultLib.sol#376)
• reservedDs >= ctAmm (contracts/libraries/VaultLib.sol#381)

Expiry.isExpired() (contracts/core/assets/Asset.sol#51-57) uses timestamp for comparisons Dangerous comparisons:

• block.timestamp >= TIMESTAMP (contracts/core/assets/Asset.sol#56)

VaultLibrary._redeemCtDsAndSellExcessCt(State,uint256,IUniswapV2Router02,IDsFlashSwapCore,uint256) (contracts/libraries/VaultLib.sol#318-347) uses timestamp for comparisons Dangerous comparisons:

• ctSellAmount != 0 (contracts/libraries/VaultLib.sol#343)
• reservedDs >= ammCtBalance (contracts/libraries/VaultLib.sol#327)
• reservedDs >= ammCtBalance (contracts/libraries/VaultLib.sol#334)

VaultLibrary.__provideLiquidity(State,uint256,uint256,IDsFlashSwapCore,address,IUniswapV2Router02,uint256) (contracts/libraries/VaultLib.sol#153-172) uses timestamp for comparisons Dangerous comparisons:

• raAmount == 0 && ctAmount == 0 (contracts/libraries/VaultLib.sol#163) Expiry.constructor(uint256) (contracts/core/assets/Asset.sol#40-46) uses timestamp for comparisons Dangerous comparisons:
• _expiry != 0 && _expiry < block.timestamp (contracts/core/assets/Asset.sol#41)

Vulnerability Detail

Impact

Code Snippet

Tool used

Manual Review

Recommendation

[siddhpurakaran]

most of comparisons mentioned in this issue are based on amount but issue saying it is based on timestamp. So marking this as invalid issue and will not fix it