Closed sherlock-admin4 closed 3 weeks ago
Gentle Gingham Urchin
Low/Info
https://github.com/sherlock-audit/2024-08-tokamak-network/blob/main/tokamak-thanos/packages/tokamak/contracts-bedrock/src/universal/CrossDomainMessenger.sol#L283
In relayMessage function of CrossDomainMessenger.sol
xDomainMsgSender = _sender; bool success = SafeCall.call(_target, gasleft() - RELAY_RESERVED_GAS, _value, _message); xDomainMsgSender = Constants.DEFAULT_L2_SENDER;
xDomainMsgSender is written twice.
Manual Review
Need to remove "xDomainMsgSender = _sender;".
Gentle Gingham Urchin
Low/Info
Useless code
Summary
https://github.com/sherlock-audit/2024-08-tokamak-network/blob/main/tokamak-thanos/packages/tokamak/contracts-bedrock/src/universal/CrossDomainMessenger.sol#L283
In relayMessage function of CrossDomainMessenger.sol
xDomainMsgSender is written twice.
Tool used
Manual Review
Recommendation
Need to remove "xDomainMsgSender = _sender;".