shift-org / shift-docs

Shift2Bikes: website and calendar for shift and pedalpalooza
https://shift2bikes.org
Other
22 stars 17 forks source link

[node] consider a graceful failure in case of npm package snafu #683

Open fool opened 7 months ago

fool commented 7 months ago

It seems like at present if something went wrong during npm install, the site would be broken until we reverted/cleaned up the problem (since it tears down the old install before starting the now-broken one and thus it fails in a broken state).

We should make this more resilient / smarter (e.g. work in a copy of the image to ensure it builds and then swap the copy in?)

ionous commented 7 months ago

maybe something like this might work to wait and check for node to have written its startup message https://www.marksayson.com/blog/wait-until-docker-containers-initialized/