shift-org / shift-docs

Shift2Bikes: website and calendar for shift and pedalpalooza
https://shift2bikes.org
Other
22 stars 17 forks source link

remove animate.css #781

Closed ionous closed 3 weeks ago

ionous commented 1 month ago

i looking at https://github.com/shift-org/shift-docs/pull/775 -- i noticed this animate.css

Screenshot 2024-07-10 at 12 05 21 AM

i went through the classes in it, and i couldn't find any being used.

the drop down menus seem to be using jquery

https://github.com/shift-org/shift-docs/blob/766967d0b4f90e0b4013e12fb605f6d140a24a49/site/themes/s2b_hugo_theme/static/js/front.js#L40

and maybe some css transitions?

https://github.com/shift-org/shift-docs/blob/766967d0b4f90e0b4013e12fb605f6d140a24a49/site/themes/s2b_hugo_theme/static/css/style.default.css#L363

as is the "scroll to top widget" https://github.com/shift-org/shift-docs/blob/766967d0b4f90e0b4013e12fb605f6d140a24a49/site/themes/s2b_hugo_theme/static/js/cal/main.js#L217

the publish/delete modal is using bootstrap and its animations: https://getbootstrap.com/docs/3.4/javascript/#modals-examples

i deleted it locally, and removed the reference from head, and couldn't see any visual differences.

https://github.com/shift-org/shift-docs/blob/766967d0b4f90e0b4013e12fb605f6d140a24a49/site/themes/s2b_hugo_theme/layouts/partials/head.html#L34

it compresses down to 4k in production ... but still... feels like we should remove it. ( phew, and look at the size before the min changes! )

Screenshot 2024-07-10 at 12 03 26 AM
ionous commented 1 month ago

( ^ @carrythebanner for eyes )