shinate / gulp-version-number

Add version number to js/css/image in HTML
MIT License
24 stars 19 forks source link

Use native fs #13

Open LC43 opened 4 years ago

LC43 commented 4 years ago

fsPath has a known vulnerability and had no updates from a long time. This PR will revert the dependency added to fix recursive writes while updating the call with the native functions.

Note that this requires a node version > 11.5 where these asynchronous functions where introduced. Set as >=12 to use the LTS versions.

I don't think this breaks backward compatibility but does require a newer version of node.

Testing

I ran the existing tests and it worked. I didn't expect the image to have a different md5, but there wasn't actually a image to start.

On my own tests, it was successful in creating recursively many directories and replacing the target.

nemanjapetrovic commented 4 years ago

Hi @shinate ,

can you please merge this PR? Thanks you in advance!