search

shingarov / Pharo-ArchC

Generate binutils from formal spec
MIT License
4 stars 1 forks source link

Cleanup (part 3) #16

Closed janvrany closed 1 year ago

janvrany commented 1 year ago

This PR is just another batch of small clean-ups and refactoring to simplify the code while preparing ground for "label" pseudo instruction (which will come in another PR)

shingarov commented 1 year ago

Can you split 8d97e30 into its parts? because #to:do: is not the only thing this commit changes.

After that, I would like to drop the actual #to:do: change. We are in the middle of thinking about what #do: does as a concept, and how to express its contract in any of the Floyd­–Hoare extensions we have on the table. Having to simultaneously think about whether/how #to:do: factors through #do: just hurts too much.

janvrany commented 1 year ago

I dropped 8d97e30 altogether - the other changes got in by accident and while they may still come in some later PR, I'm not yet 100% sure they're good, especially the lift of #disassemble to insn declaration. Sorry for the noise.