search

shingarov / Pharo-ArchC

Generate binutils from formal spec
MIT License
4 stars 1 forks source link

Fix `AcInstrDecodeTest>>testPowerAddiSymbolic` #36

Closed shingarov closed 3 months ago

shingarov commented 4 months ago

A trivial push yesterday (classifying a method) re-triggered CI and now https://github.com/shingarov/Pharo-ArchC/actions/runs/9171675951/job/25216516144 . I don't understand how this could possibly pass before.

janvrany commented 4 months ago

I don't understand how this could possibly pass before.

Neither do I, not yet. But this is worth investigating...

janvrany commented 4 months ago

I don't understand how this could possibly pass before.

It did pass before MA commit https://github.com/shingarov/MachineArithmetic/commit/216a5c8fd329ef2a7e1758edbcaef5cccf0a0e57.

This is because the before that, in signedValue there was: 

self simplify isNumeral ifFalse: [ ^self ].

The problem is fieldValue: returns sometimes an integer, sometimes Z3Int and sometimes bitvector. Worse, it tells you it does return an Integer.