search

shirou / gopsutil

psutil for golang
Other
10.68k stars 1.59k forks source link

feat(mem): Add windows commit stats #1720

Closed n4nn31355 closed 1 month ago

n4nn31355 commented 1 month ago

I'm kinda puzzled if I should avoid calling procGetPerformanceInfo and stick to computing commit stats from memoryStatusEx.ullTotalPageFile and memoryStatusEx.ullAvailPageFile or expose pagefile stats and compute it in final application.

However, I chose this implementation because it is more aligned with the terminology used by Windows Task Manager and Powershell's Get-Counter, both of which refer to "commit" rather than "pagefile."

Closes #1719

n4nn31355 commented 1 month ago

@shirou just a gentle reminder Could you please let me know if this can be merged or if you have any feedback I should address?