search

shogg / edifact

Read edifact into your Go data structures.
MIT License
18 stars 7 forks source link

Refactor and move most of declarative spec into edifact to simplify. #8

Open shogg opened 2 years ago

shogg commented 2 years ago

Don't make build and parse internal for now.

shogg commented 10 months ago

This doesn't seem to be possible easily. I want to retain the implementation packages to hide complexity. But with them you get circular package dependencies when moving essential types to edifact. The idea is to have all user code in edifact. But for now you have to use spec.S instead of edifact.S to specify edifact document formats.

shogg commented 7 months ago

It is possible with a 'spec/edifact' package. Before pushing that, I should probably first establish Semver and breaking changes. Although the current code does not promise any security against breaking changes, because it does not have a major version.

The breaking change would be like this: 'spec.S' -> 'edifact.S' for edi document specifactions. And you would have to import the spec package "github.com/shogg/edifact/spec/edifact".

Tell me, if it is ok to bring in this braking change or, if I should make it a separate, independent branch and version.