shower / cli

Command line interface for Shower
Other
35 stars 6 forks source link

Hardcode should be removed #28

Closed SilentImp closed 5 years ago

SilentImp commented 5 years ago

https://github.com/shower/cli/blob/5f98c7bcda1094a24e22973b7687f48779b4b3db/source/index.js#L12

Why do you hardcode it? but this version of ${pkg.name} requires Node ${chalk.bold(pkg.engines.node)}.\n — do it like this. Hardcode is bad practice.