search

shower / cli

Command line interface for Shower
Other
35 stars 6 forks source link

Add flag `--yes` from `create` task (#33) #45

Closed kostyabushuev closed 5 years ago

mrdimidium commented 5 years ago

Fixed #33

mrdimidium commented 5 years ago

Hey. Thank you for PR. I wrote commen about why the flag should be called --yes and not --all. Let's rename it?

mrdimidium commented 5 years ago

Also, now you've added a parameter, just a positional string, and you need a flag. It can be added using the option method instead of the positional method

kostyabushuev commented 5 years ago

@nikolay-govorov

  1. change to '--all'
  2. use option instead of positional

update commit

mrdimidium commented 5 years ago

Thanks for the help, merge this :D