search

shreeshailaya / C-DAC-Notes

work in progress...
https://shreeshail.gitbook.io/c-dac-notes/
GNU General Public License v3.0
32 stars 49 forks source link

Update Readme.md #127

Closed Mahesh-Prayaga closed 1 year ago

Mahesh-Prayaga commented 1 year ago

Removed all typos and grammatical mistakes. Also added Basic Time complexity notes/

shreeshailaya commented 1 year ago

I'm closing this because of the given reason...

Mahesh-Prayaga commented 1 year ago

Hey, Vitkar.

      I am Mahesh. Today i made my first contribution, Thanks for

approving it. I get why you closed it. I just wanted to ask you an another question, Which is, If i made four Pull requests about completing four sorting algorithms, is that okay? or is there a rule that says i should make them all in one single PR? Also, i want to know if i can make atleast two PRs, 1 being a typo clearer and 2 being making the notes. please help this noob contributor out.

On Sun, 2 Oct 2022 at 19:59, Shreeshail Vitkar @.***> wrote:

Closed #127 https://github.com/shreeshailaya/C-DAC-Notes/pull/127.

— Reply to this email directly, view it on GitHub https://github.com/shreeshailaya/C-DAC-Notes/pull/127#event-7502103048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY73ALBIKNQZ65BQD4W2SI3WBGL5HANCNFSM6AAAAAAQ232BRI . You are receiving this because you authored the thread.Message ID: @.***>

shreeshailaya commented 1 year ago

hello @MaheshPrayaga, thank you for your great efforts, but before contributing first read the issue properly Write notes about Time and Space Complexity in Data Structure #115 so that you have to write notes on time and space complexity also need to write programs which are in java and the programs should be in code quote like java <your code will be here> (google how to write java code in GitHub readme.md )