search

siddharthkp / cost-of-modules

Find out which of your dependencies are slowing you down 🐢
MIT License
2.84k stars 41 forks source link

Feature: Read bower dependencies #29

Closed dphochman closed 7 years ago

dphochman commented 7 years ago

In my app (based on angular-seed), the runtime dependencies are installed by bower install which is triggered by npm script postinstall, and not detected by cost-of-modules. bower.json declares the runtime dependencies, and .bowerrc declares the directory where the dependencies are installed (the default directory is bower_components/).

I realize that this request may lead to a vortex of unreachable goals, such as a deep understanding of the impact of specific npm scripts, obscure options in bower, or supporting other package managers. Perhaps each of those can be prioritized and tackled independently. AFAIK, using bower for runtime dependencies is a popular practice.

siddharthkp commented 7 years ago

Can't deny that bower is still pretty popular. But, that sounds like another project of it's own. Wouldn't want to add that to this repo.

What do you think?

dphochman commented 7 years ago

Of course, you are correct. Small pieces loosely joined...

If it's OK with you to fork or require "cost-of-modules" to jumpstart a "cost-of-packages" or "cost-of-bower" package, that's the route I'll pursue. If it works, I may attempt to register it on bower.io. And that may lead me or others to enter the above-mentioned vortex.

Thank you for this work.

siddharthkp commented 7 years ago

@dphochman Of course! Go for it!