Fix warnings for renmaed methods and unsupported test methods - Githubissues

sideeffect-io / AsyncExtensions

AsyncExtensions aims to mimic Swift Combine operators for async sequences.

MIT License

324 stars 26 forks source link

Fix warnings for renmaed methods and unsupported test methods #36

Open kdubb opened 1 year ago

kdubb commented 1 year ago

Code

Updates all old signature withTaskCancellationHandler methods. Requires is a simple reordering of the closure parameters.

The “new” signature is already used in the code so shouldn’t have an impact on platform/swift version support.

Tests

Repalces all await wait(for:timeout:) and waitForExpectations with await fulfillment(of:timeout:)

The current use of await wait(for:timeout:) and waitForExpectations(timeout:) has been deprecated in async test methods due to a possibility of deadlocking the test (see https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3-release-notes)

Description

Checklist

[X] this PR is based on the main branch and is up-to-date, if not please rebase your branch on the top of main
[X] the commits inside this PR have explicit commit messages
[X] unit tests cover the new feature or the bug fix
[X] the feature is documented in the README.md if it makes sense
[X] the CHANGELOG is up-to-date