sifive / cinco

Port of Arduino environment for Freedom E 300 Dev Kit & HiFive Board
31 stars 21 forks source link

Add interrupts and clean up compile warnings. #8

Closed mwachs5 closed 7 years ago

mwachs5 commented 7 years ago

Added interrupts, and bumped freedom-e-sdk to pick up the updated platform.h headers.

There continues to be a lot of duplicate code (the plic_driver code, and entry.S, for example).

Also, the start.S is completely different in freedom-e-sdk, is it wrong? I think it would be better if we could include the "correct" versions in the SDK and sim link in the Arduino directory if we have to.

a0u commented 7 years ago

Also, the start.S is completely different in freedom-e-sdk, is it wrong? I think it would be better if we could include the "correct" versions in the SDK and sim link in the Arduino directory if we have to.

The Arduino version of start.S is more proper/robust in the sense that it uses newlib's own initialization functions instead of inexactly re-implementing them. I believe we should replace freedom-e-sdk's with this one and deduplicate, but we need to confirm the demos and dhrystone still work.