search

sifive / freedom-tools

Tools for SiFive's Freedom Platform
217 stars 52 forks source link

Trace decoder libs #31

Closed bradseevers closed 4 years ago

bradseevers commented 4 years ago

Makefile mods to create position independant code libs on ubuntu for trace decoder.

cgsfv commented 4 years ago

The src/trace-decoder submodule is still pointing to a very old version. Please update it to point to the correct commit of the trace-decoder.

bradseevers commented 4 years ago

Okay - no problem! But I have just passed my knowledge of git! Do I make this change in the trace-decoder, or in freedom-tools? Can you give me a hint on how to do this?

Thanks!

-brad

On Mon, Feb 3, 2020 at 10:27 AM Carsten Gosvig notifications@github.com wrote:

The src/trace-decoder submodule is still pointing to a very old version. Please update it to point to the correct commit of the trace-decoder.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7RXDD2HDT3WWPRJKJLRBBOY5A5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKU4FGY#issuecomment-581550747, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7U4QR4MLR6JNJI37PDRBBOY5ANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

I have found this webpage, which I found very useful with a very good explanation on how to do this: [https://chrisjean.com/git-submodules-adding-using-removing-and-updating/]

You need to the change in freedom-tools:

bradseevers commented 4 years ago

Carsten,

I followed your instructions. The trace-decoder-libs branch has been updated to use the latest version of trace-decoder master.

Let me know if I messed anything up!

Thanks,

-brad

On Mon, Feb 3, 2020 at 10:56 AM Carsten Gosvig notifications@github.com wrote:

I have found this webpage, which I found very useful with a very good explanation on how to do this: [https://chrisjean.com/git-submodules-adding-using-removing-and-updating/]

You need to the change in freedom-tools:

  • cd src/trace-decoder
  • git checkout master
  • git pull
  • if you want something else than master: git checkout
  • cd ../..
  • git add src/trace-decoder (without a trailing / !!!!)
  • git commit -m "your commit message"
  • git push

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7Q6SBGZXAE3BDKDC2DRBBSHHA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKU7EOA#issuecomment-581562936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7US5GS3FDQ7PHZVGIDRBBSHHANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

I'm guessing I need to cancel my PR and create a new one?

-brad

On Mon, Feb 3, 2020 at 6:29 PM Brad Seevers brad.seevers@sifive.com wrote:

Carsten,

I followed your instructions. The trace-decoder-libs branch has been updated to use the latest version of trace-decoder master.

Let me know if I messed anything up!

Thanks,

-brad

On Mon, Feb 3, 2020 at 10:56 AM Carsten Gosvig notifications@github.com wrote:

I have found this webpage, which I found very useful with a very good explanation on how to do this: [https://chrisjean.com/git-submodules-adding-using-removing-and-updating/ ]

You need to the change in freedom-tools:

  • cd src/trace-decoder
  • git checkout master
  • git pull
  • if you want something else than master: git checkout
  • cd ../..
  • git add src/trace-decoder (without a trailing / !!!!)
  • git commit -m "your commit message"
  • git push

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7Q6SBGZXAE3BDKDC2DRBBSHHA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKU7EOA#issuecomment-581562936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7US5GS3FDQ7PHZVGIDRBBSHHANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

No, the PR is fine - it is updated with the update of the trace-decoder submodule. I will continue my look at your solution.

cgsfv commented 4 years ago

When building on my mac, I got this error: swig not found

sifivekevin commented 4 years ago

You might have to install swig on the Mac. Probably available via Homebrew.

On Tue, Feb 4, 2020, 11:56 AM Carsten Gosvig notifications@github.com wrote:

When building on my mac, I got this error: swig not found

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=AKJGHLCDE4ZBDGEZGAUUDRTRBHCATA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKY7FXA#issuecomment-582087388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJGHLCI5XSMNG3IECZMMSLRBHCATANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

OK - which version of SWIG are you using?

sifivekevin commented 4 years ago

The latest version should be fine. We can check when we get back to the offices.

On Tue, Feb 4, 2020, 12:05 PM Carsten Gosvig notifications@github.com wrote:

OK - which version of SWIG are you using?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=AKJGHLDMVSFTH2JPYXJJSBTRBHDBFA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZABJY#issuecomment-582090919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJGHLEVCIQPTM2SIBHZVEDRBHDBFANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

Install SWIG. Next error: JNIINCLUDE not defined

bradseevers commented 4 years ago

If JNIINCLUDE is not defined, it just skips building the swig shared library. More informational than an error, unless you are trying to build the swig shared libary - which you are!

Set JNIINCLUDE to the path to the java include files on your system. For example, on my linux system I do a:

export JNIINCLUDE="/usr/lib/jvm/java-11-openjdk-amd64/include

-brad

On Tue, Feb 4, 2020 at 12:27 PM Carsten Gosvig notifications@github.com wrote:

Install SWIG. Next error: JNIINCLUDE not defined

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7SJUR5V3QHJPZ77TLLRBHFR3A5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZCEDI#issuecomment-582099469, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7STTCJ3CEC42HECQ3DRBHFR3ANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

I would expect this to be setup/handled in the trace-decoder Makefile. Can you do that - I guess there must be some way to query java about that?

sifivekevin commented 4 years ago

I don't know if you can query Java for that path. I've always had to rely on environment variables set on each system to point to the right place. And using said envar allows every developer to configure their system as they see fit (putting java where they like it)..

On Tue, Feb 4, 2020 at 2:20 PM Carsten Gosvig notifications@github.com wrote:

I would expect this to be setup/handled in the trace-decoder Makefile. Can you do that - I guess there must be some way to query java about that?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=AKJGHLDCOP2BKQLGGDFF4VTRBHSZBA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZM7RI#issuecomment-582143941, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJGHLFVO2K53KN2BF6E3FDRBHSZBANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

My thoughts were I didn't want to do it in the makefile. I wanted the user to be able to control whether or not they wanted to build the java stuff. If it isn't set, it skips it. If they aren't interested in Java, they don't need to worry about swig or java.

-brad

On Tue, Feb 4, 2020 at 2:20 PM Carsten Gosvig notifications@github.com wrote:

I would expect this to be setup/handled in the trace-decoder Makefile. Can you do that - I guess there must be some way to query java about that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7WSFR2I3Y5SDBXVXRDRBHSZBA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZM7RI#issuecomment-582143941, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7VKOFU5JUYNOS7A5TDRBHSZBANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

I think I could do it in the makefile if that is what we want to do.

-brad

On Tue, Feb 4, 2020 at 2:28 PM Brad Seevers brad.seevers@sifive.com wrote:

My thoughts were I didn't want to do it in the makefile. I wanted the user to be able to control whether or not they wanted to build the java stuff. If it isn't set, it skips it. If they aren't interested in Java, they don't need to worry about swig or java.

-brad

On Tue, Feb 4, 2020 at 2:20 PM Carsten Gosvig notifications@github.com wrote:

I would expect this to be setup/handled in the trace-decoder Makefile. Can you do that - I guess there must be some way to query java about that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7WSFR2I3Y5SDBXVXRDRBHSZBA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZM7RI#issuecomment-582143941, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7VKOFU5JUYNOS7A5TDRBHSZBANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

I also like to be able to configure stuff myself. But the purpose of freedom-tools is that it should be easy to build the tools. Meaning that there should be a default configuration that builds everything as it should be - meaning what we release and use in Freedom Studio - without any additional configuration needed.

I have it on my list to also add checking of all the dependencies listed in the README.md file.

bradseevers commented 4 years ago

I will see if I can add the JNIINCLUDE computation to the makefile.

-brad

On Tue, Feb 4, 2020 at 2:32 PM Carsten Gosvig notifications@github.com wrote:

I also like to be able to configure stuff myself. But the purpose of freedom-tools is that it should be easy to build the tools. Meaning that there should be a default configuration that builds everything as it should be - meaning what we release and use in Freedom Studio - without any additional configuration needed.

I have it on my list to also add checking of all the dependencies listed in the README.md file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QKK3VVA767GIV4JF3RBHUJRA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZOC6Y#issuecomment-582148475, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7UTL6WJ745HDPMRWJDRBHUJRANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Well, I have a really nice solution, except it doesn't work! It works fine if there are no spaces in the path to the java include directory. Make's $(abspath X) treats X as multiple arguments if it contains spaces, and give a completely different answer than desired. There doesn't seem to be any way to quote spaces in make. (You can quote like crazy, but it doesn't seem to make a difference)

Since on windows java installs in \program files\, which contains a space, this is a problem. Is working great on linux.

I haven't given up yet.

-brad

On Tue, Feb 4, 2020 at 2:35 PM Brad Seevers brad.seevers@sifive.com wrote:

I will see if I can add the JNIINCLUDE computation to the makefile.

-brad

On Tue, Feb 4, 2020 at 2:32 PM Carsten Gosvig notifications@github.com wrote:

I also like to be able to configure stuff myself. But the purpose of freedom-tools is that it should be easy to build the tools. Meaning that there should be a default configuration that builds everything as it should be - meaning what we release and use in Freedom Studio - without any additional configuration needed.

I have it on my list to also add checking of all the dependencies listed in the README.md file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QKK3VVA767GIV4JF3RBHUJRA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZOC6Y#issuecomment-582148475, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7UTL6WJ745HDPMRWJDRBHUJRANCNFSM4KPIT5LQ .

sifivekevin commented 4 years ago

I think it is OK to mandate (for people wanting to build freedom-tools, or the trace-decode standalone) that dependencies be installed in paths that contain no spaces. That "requirement" is almost ubiquitous in the GNU world. What do you think, Carsten?

On Tue, Feb 4, 2020 at 4:29 PM Bradley Seevers notifications@github.com wrote:

Well, I have a really nice solution, except it doesn't work! It works fine if there are no spaces in the path to the java include directory. Make's $(abspath X) treats X as multiple arguments if it contains spaces, and give a completely different answer than desired. There doesn't seem to be any way to quote spaces in make. (You can quote like crazy, but it doesn't seem to make a difference)

Since on windows java installs in \program files\, which contains a space, this is a problem. Is working great on linux.

I haven't given up yet.

-brad

On Tue, Feb 4, 2020 at 2:35 PM Brad Seevers brad.seevers@sifive.com wrote:

I will see if I can add the JNIINCLUDE computation to the makefile.

-brad

On Tue, Feb 4, 2020 at 2:32 PM Carsten Gosvig notifications@github.com wrote:

I also like to be able to configure stuff myself. But the purpose of freedom-tools is that it should be easy to build the tools. Meaning that there should be a default configuration that builds everything as it should be - meaning what we release and use in Freedom Studio - without any additional configuration needed.

I have it on my list to also add checking of all the dependencies listed in the README.md file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QKK3VVA767GIV4JF3RBHUJRA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZOC6Y#issuecomment-582148475 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALEGT7UTL6WJ745HDPMRWJDRBHUJRANCNFSM4KPIT5LQ

.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=AKJGHLAVCHDLYJGVYLZ6D6LRBIB6BA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZWWEA#issuecomment-582183696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJGHLDAOFKCBJILU43HK23RBIB6BANCNFSM4KPIT5LQ .

sifivekevin commented 4 years ago

BTW: On my windows machine I make sure everything needed to build is installed in space-free locations.

On Tue, Feb 4, 2020 at 4:53 PM Kevin Mills kevin.mills@sifive.com wrote:

I think it is OK to mandate (for people wanting to build freedom-tools, or the trace-decode standalone) that dependencies be installed in paths that contain no spaces. That "requirement" is almost ubiquitous in the GNU world. What do you think, Carsten?

On Tue, Feb 4, 2020 at 4:29 PM Bradley Seevers notifications@github.com wrote:

Well, I have a really nice solution, except it doesn't work! It works fine if there are no spaces in the path to the java include directory. Make's $(abspath X) treats X as multiple arguments if it contains spaces, and give a completely different answer than desired. There doesn't seem to be any way to quote spaces in make. (You can quote like crazy, but it doesn't seem to make a difference)

Since on windows java installs in \program files\, which contains a space, this is a problem. Is working great on linux.

I haven't given up yet.

-brad

On Tue, Feb 4, 2020 at 2:35 PM Brad Seevers brad.seevers@sifive.com wrote:

I will see if I can add the JNIINCLUDE computation to the makefile.

-brad

On Tue, Feb 4, 2020 at 2:32 PM Carsten Gosvig <notifications@github.com

wrote:

I also like to be able to configure stuff myself. But the purpose of freedom-tools is that it should be easy to build the tools. Meaning that there should be a default configuration that builds everything as it should be - meaning what we release and use in Freedom Studio - without any additional configuration needed.

I have it on my list to also add checking of all the dependencies listed in the README.md file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QKK3VVA767GIV4JF3RBHUJRA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZOC6Y#issuecomment-582148475 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALEGT7UTL6WJ745HDPMRWJDRBHUJRANCNFSM4KPIT5LQ

.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=AKJGHLAVCHDLYJGVYLZ6D6LRBIB6BA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZWWEA#issuecomment-582183696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJGHLDAOFKCBJILU43HK23RBIB6BANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

You don't install in c:\Program Files\?

On Tue, Feb 4, 2020 at 4:54 PM Kevin Mills notifications@github.com wrote:

BTW: On my windows machine I make sure everything needed to build is installed in space-free locations.

On Tue, Feb 4, 2020 at 4:53 PM Kevin Mills kevin.mills@sifive.com wrote:

I think it is OK to mandate (for people wanting to build freedom-tools, or the trace-decode standalone) that dependencies be installed in paths that contain no spaces. That "requirement" is almost ubiquitous in the GNU world. What do you think, Carsten?

On Tue, Feb 4, 2020 at 4:29 PM Bradley Seevers <notifications@github.com

wrote:

Well, I have a really nice solution, except it doesn't work! It works fine if there are no spaces in the path to the java include directory. Make's $(abspath X) treats X as multiple arguments if it contains spaces, and give a completely different answer than desired. There doesn't seem to be any way to quote spaces in make. (You can quote like crazy, but it doesn't seem to make a difference)

Since on windows java installs in \program files\, which contains a space, this is a problem. Is working great on linux.

I haven't given up yet.

-brad

On Tue, Feb 4, 2020 at 2:35 PM Brad Seevers brad.seevers@sifive.com wrote:

I will see if I can add the JNIINCLUDE computation to the makefile.

-brad

On Tue, Feb 4, 2020 at 2:32 PM Carsten Gosvig < notifications@github.com

wrote:

I also like to be able to configure stuff myself. But the purpose of freedom-tools is that it should be easy to build the tools. Meaning that there should be a default configuration that builds everything as it should be - meaning what we release and use in Freedom Studio - without any additional configuration needed.

I have it on my list to also add checking of all the dependencies listed in the README.md file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QKK3VVA767GIV4JF3RBHUJRA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZOC6Y#issuecomment-582148475

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ALEGT7UTL6WJ745HDPMRWJDRBHUJRANCNFSM4KPIT5LQ

.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub < https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=AKJGHLAVCHDLYJGVYLZ6D6LRBIB6BA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZWWEA#issuecomment-582183696 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AKJGHLDAOFKCBJILU43HK23RBIB6BANCNFSM4KPIT5LQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QZMWYO2GIHX5UJ33LRBIE53A5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZYGRA#issuecomment-582189892, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7TKA2GRXHENNIHTIBDRBIE53ANCNFSM4KPIT5LQ .

sifivekevin commented 4 years ago

NEVER! Unless it is a native Windows app unrelated to any development work I do. I might be a Windows fanboy, but I know when cry "Uncle". :)

On Tue, Feb 4, 2020 at 4:55 PM Bradley Seevers notifications@github.com wrote:

You don't install in c:\Program Files\?

On Tue, Feb 4, 2020 at 4:54 PM Kevin Mills notifications@github.com wrote:

BTW: On my windows machine I make sure everything needed to build is installed in space-free locations.

On Tue, Feb 4, 2020 at 4:53 PM Kevin Mills kevin.mills@sifive.com wrote:

I think it is OK to mandate (for people wanting to build freedom-tools, or the trace-decode standalone) that dependencies be installed in paths that contain no spaces. That "requirement" is almost ubiquitous in the GNU world. What do you think, Carsten?

On Tue, Feb 4, 2020 at 4:29 PM Bradley Seevers < notifications@github.com

wrote:

Well, I have a really nice solution, except it doesn't work! It works fine if there are no spaces in the path to the java include directory. Make's $(abspath X) treats X as multiple arguments if it contains spaces, and give a completely different answer than desired. There doesn't seem to be any way to quote spaces in make. (You can quote like crazy, but it doesn't seem to make a difference)

Since on windows java installs in \program files\, which contains a space, this is a problem. Is working great on linux.

I haven't given up yet.

-brad

On Tue, Feb 4, 2020 at 2:35 PM Brad Seevers brad.seevers@sifive.com wrote:

I will see if I can add the JNIINCLUDE computation to the makefile.

-brad

On Tue, Feb 4, 2020 at 2:32 PM Carsten Gosvig < notifications@github.com

wrote:

I also like to be able to configure stuff myself. But the purpose of freedom-tools is that it should be easy to build the tools. Meaning that there should be a default configuration that builds everything as it should be - meaning what we release and use in Freedom Studio - without any additional configuration needed.

I have it on my list to also add checking of all the dependencies listed in the README.md file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QKK3VVA767GIV4JF3RBHUJRA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZOC6Y#issuecomment-582148475

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ALEGT7UTL6WJ745HDPMRWJDRBHUJRANCNFSM4KPIT5LQ

.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <

https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=AKJGHLAVCHDLYJGVYLZ6D6LRBIB6BA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZWWEA#issuecomment-582183696

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AKJGHLDAOFKCBJILU43HK23RBIB6BANCNFSM4KPIT5LQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QZMWYO2GIHX5UJ33LRBIE53A5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZYGRA#issuecomment-582189892 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALEGT7TKA2GRXHENNIHTIBDRBIE53ANCNFSM4KPIT5LQ

.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=AKJGHLGBGQSSQZAQ4LRBS4TRBIFBHA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZYIIY#issuecomment-582190115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJGHLHI3UDHO3YK5LTL2L3RBIFBHANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

I fully agree! And btw. freedom-tools is not specified to build on windows. We only support building on linux and mac. So it's fine if it only works if there are no spaces in the paths.

bradseevers commented 4 years ago

Just updated makefile.init in the tace-encoder to compute JNIINCLUDE based on where it finds javac. This does not work if there are spaces in the path. JNIINCLUDE can be overridden by setting it in the environment or passing it on the make command line (but you shouldn't need to).

Carston, do I need to generate a new PR?

Thanks,

-brad

On Tue, Feb 4, 2020 at 5:09 PM Carsten Gosvig notifications@github.com wrote:

I fully agree! And btw. freedom-tools is not specified to build on windows. We only support building on linux and mac. So it's fine if it only works if there are no spaces in the paths.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7ROWSI4Q5ZCEEHTV3TRBIGUTA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZZDUY#issuecomment-582193619, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7W3W34DRUEPT54KO3LRBIGUTANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

No, you just need to update the trace-decoder submodule to point to the new commit of that.

bradseevers commented 4 years ago

Will do!

On Wed, Feb 5, 2020 at 9:03 AM Carsten Gosvig notifications@github.com wrote:

No, you just need to update the trace-decoder submodule to point to the new commit of that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QKLQANKAS6NEAMFZTRBLWOXA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4GCNY#issuecomment-582508855, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7WAABQC5NAJJ7W24ODRBLWOXANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Carsten,

I think I have updated the freedom-tools trace-decoder submodule to point to the updated trace-decoder. Let me know if I messed it up!

-brad

On Wed, Feb 5, 2020 at 9:20 AM Brad Seevers brad.seevers@sifive.com wrote:

Will do!

On Wed, Feb 5, 2020 at 9:03 AM Carsten Gosvig notifications@github.com wrote:

No, you just need to update the trace-decoder submodule to point to the new commit of that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QKLQANKAS6NEAMFZTRBLWOXA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4GCNY#issuecomment-582508855, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7WAABQC5NAJJ7W24ODRBLWOXANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

I got further with the build, but it stops with this error in the make-build.log: Building file dqr_wrap.o Invoking: GCC C++ Compiler g++ -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -c dqr_wrap.cpp -I"../include" -I"/System/Library/Frameworks/JavaVM.framework/Versions/A/Commands/javac" -I"/System/Library/Frameworks/JavaVM.framework/Versions/A/Commands/javac/darwin" dqr_wrap.cpp:181:10: fatal error: 'jni.h' file not found

include 

     ^~~~~~~

1 error generated.

When I run java --version on my Mac, I get: openjdk 11.0.5 2019-10-15 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.5+10) Eclipse OpenJ9 VM AdoptOpenJDK (build openj9-0.17.0, JRE 11 Mac OS X amd64-64-Bit Compressed References 20191016_371 (JIT enabled, AOT enabled) OpenJ9 - 77c1cf708 OMR - 20db4fbc JCL - 2a7af5674b based on jdk-11.0.5+10)

bradseevers commented 4 years ago

Could you send me your entire make.log for the trace decoder?

Also, where on your system is java installed?

Thanks,

-brad

On Wed, Feb 5, 2020 at 1:01 PM Carsten Gosvig notifications@github.com wrote:

I got further with the build, but it stops with this error in the make-build.log: Building file dqr_wrap.o Invoking: GCC C++ Compiler g++ -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -c dqr_wrap.cpp -I"../include" -I"/System/Library/Frameworks/JavaVM.framework/Versions/A/Commands/javac" -I"/System/Library/Frameworks/JavaVM.framework/Versions/A/Commands/javac/darwin" dqr_wrap.cpp:181:10: fatal error: 'jni.h' file not found

include

^~~ 1 error generated.

When I run java --version on my Mac, I get: openjdk 11.0.5 2019-10-15 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.5+10) Eclipse OpenJ9 VM AdoptOpenJDK (build openj9-0.17.0, JRE 11 Mac OS X amd64-64-Bit Compressed References 20191016_371 (JIT enabled, AOT enabled) OpenJ9 - 77c1cf708 OMR - 20db4fbc JCL - 2a7af5674b based on jdk-11.0.5+10)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7SSEOP7IVQLRJ7VQRTRBMSLPA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4644Q#issuecomment-582610546, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7XQRC4PSG4L3EVVVHTRBMSLPANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

/Library/Developer/CommandLineTools/usr/bin/make -C lib NEWLIBPATH=/scratch/carsteng/git/freedom-tools-tdl/obj/x86_64-apple-darwin/build/riscv-gnu-toolchain/build-binutils-newlib all cp /scratch/carsteng/git/freedom-tools-tdl/obj/x86_64-apple-darwin/build/riscv-gnu-toolchain/build-binutils-newlib/bfd/libbfd.a macos cp /scratch/carsteng/git/freedom-tools-tdl/obj/x86_64-apple-darwin/build/riscv-gnu-toolchain/build-binutils-newlib/opcodes/libopcodes.a macos cp /scratch/carsteng/git/freedom-tools-tdl/obj/x86_64-apple-darwin/build/riscv-gnu-toolchain/build-binutils-newlib/libiberty/libiberty.a macos cp /scratch/carsteng/git/freedom-tools-tdl/obj/x86_64-apple-darwin/build/riscv-gnu-toolchain/build-binutils-newlib/intl/libintl.a macos cp /scratch/carsteng/git/freedom-tools-tdl/obj/x86_64-apple-darwin/build/riscv-gnu-toolchain/build-binutils-newlib/zlib/libz.a macos /Library/Developer/CommandLineTools/usr/bin/make -C Debug all Building file: ../src/dqr.cpp Invoking: GCC C++ Compiler g++ -I"../include" -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -c -fmessage-length=0 -MMD -MP -MF"dqr.d" -MT"dqr.o" -o "dqr.o" "../src/dqr.cpp" In file included from ../src/dqr.cpp:34: ../include/trace.hpp:303:1: warning: 'NexusMessageSync' defined as a struct here but previously declared as a class [-Wmismatched-tags] struct NexusMessageSync { ^ ../include/dqr.hpp:491:2: note: did you mean struct here? class NexusMessageSync *messageSync[DQR_MAXCORES]; ^~~~~ struct 1 warning generated. Finished building: ../src/dqr.cpp

Building file: ../src/main.cpp Invoking: GCC C++ Compiler g++ -I"../include" -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -c -fmessage-length=0 -MMD -MP -MF"main.d" -MT"main.o" -o "main.o" "../src/main.cpp" Finished building: ../src/main.cpp

Building file: ../src/trace.cpp Invoking: GCC C++ Compiler g++ -I"../include" -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -c -fmessage-length=0 -MMD -MP -MF"trace.d" -MT"trace.o" -o "trace.o" "../src/trace.cpp" In file included from ../src/trace.cpp:35: ../include/trace.hpp:303:1: warning: 'NexusMessageSync' defined as a struct here but previously declared as a class [-Wmismatched-tags] struct NexusMessageSync { ^ ../include/dqr.hpp:491:2: note: did you mean struct here? class NexusMessageSync *messageSync[DQR_MAXCORES]; ^~~~~ struct ../src/trace.cpp:1340:42: warning: expression result unused [-Wunused-value] state[currentCore = TRACE_STATE_ERROR];


2 warnings generated.
Finished building: ../src/trace.cpp

Building target: dqr
Invoking: GCC C++ Linker
g++ -L../lib/macos  -o dqr ./dqr.o ./main.o ./trace.o  -lbfd -lopcodes -liberty -lz -lintl -liconv
Finished building target: dqr

Building file dqr_wrap.cpp
Invoking: SWIG Compiler
swig -package com.sifive.trace -outdir com/sifive/trace -java -c++ -o dqr_wrap.cpp -I../include ../include/dqr.i
javac com/sifive/trace/*.java
jar cf TraceDecoder.jar com/sifive/trace/*
Finished building: dqr_wrap.cpp

Building file dqr_wrap.o
Invoking: GCC C++ Compiler
g++ -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -D OSX -std=c++11 -O0 -g3 -Wall -Wformat=0 -c dqr_wrap.cpp -I"../include" -I"/System/Library/Frameworks/JavaVM.framework/Versions/A/Commands/javac" -I"/System/Library/Frameworks/JavaVM.framework/Versions/A/Commands/javac/darwin"
dqr_wrap.cpp:181:10: fatal error: 'jni.h' file not found
#include <jni.h>
         ^~~~~~~
1 error generated.
make[2]: *** [dqr_wrap.o] Error 1
make[1]: *** [Debug] Error 2
cgsfv commented 4 years ago

$ which java /usr/bin/java

bradseevers commented 4 years ago

how about

which javac

Thanks,

-brad

On Wed, Feb 5, 2020 at 1:24 PM Carsten Gosvig notifications@github.com wrote:

$ which java /usr/bin/java

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7RHCLWLSG5FLZ6ULX3RBMVAPA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5BDXA#issuecomment-582619612, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7RRVVHIC5BLF4HRSNTRBMVAPANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

$ which javac /usr/bin/javac

bradseevers commented 4 years ago

Can you send me the trace-decoder make build log?

Thanks,

-brad

On Wed, Feb 5, 2020 at 1:25 PM Carsten Gosvig notifications@github.com wrote:

$ which javac /usr/bin/javac

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7T3RAKEWB7YZSINLULRBMVFPA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5BHXA#issuecomment-582620124, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7QZX2PBLAF6KXXVNL3RBMVFPANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

It was in the comment right before the which java comment :-)

bradseevers commented 4 years ago

Got it! Thanks!

On Wed, Feb 5, 2020 at 1:29 PM Carsten Gosvig notifications@github.com wrote:

It was in the comment right before the which java comment :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7R3WLTY67VRUNPISM3RBMVUNA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5BUCI#issuecomment-582621705, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7X2YVGJTXMM4WDFE7DRBMVUNANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Could you send me the makefile.init? Not sure it is reflecting the latest changes.

-brad

On Wed, Feb 5, 2020 at 1:30 PM Brad Seevers brad.seevers@sifive.com wrote:

Got it! Thanks!

On Wed, Feb 5, 2020 at 1:29 PM Carsten Gosvig notifications@github.com wrote:

It was in the comment right before the which java comment :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7R3WLTY67VRUNPISM3RBMVUNA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5BUCI#issuecomment-582621705, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7X2YVGJTXMM4WDFE7DRBMVUNANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Never mind - think I found an issue.

On Wed, Feb 5, 2020 at 1:35 PM Brad Seevers brad.seevers@sifive.com wrote:

Could you send me the makefile.init? Not sure it is reflecting the latest changes.

-brad

On Wed, Feb 5, 2020 at 1:30 PM Brad Seevers brad.seevers@sifive.com wrote:

Got it! Thanks!

On Wed, Feb 5, 2020 at 1:29 PM Carsten Gosvig notifications@github.com wrote:

It was in the comment right before the which java comment :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7R3WLTY67VRUNPISM3RBMVUNA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5BUCI#issuecomment-582621705, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7X2YVGJTXMM4WDFE7DRBMVUNANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

It builds on my mac - great work! Where is the trace-decoder swig library - I cannot find it in the tar.gz package built?

bradseevers commented 4 years ago

It should be in the trace-decoder/Debug lib. The windows version will be dqr.dll. On Linux and mac will will be libdqr.so.

-brad

On Thu, Feb 6, 2020 at 10:00 AM Carsten Gosvig notifications@github.com wrote:

It builds on my mac - great work! Where is the trace-decoder swig library - I cannot find it in the tar.gz package built?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7Q6XBCOSWJLX2LKJSDRBRF35A5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELAF4OQ#issuecomment-583032378, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7XQXUGPBTIB6BY3WG3RBRF35ANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

it's not in any of the bin/trace-decoder...tar.gz files did you copy the new files into the install directory?

bradseevers commented 4 years ago

No, I don’t copy the darn executable or the far lis anywhere

On Thu, Feb 6, 2020 at 12:05 PM Carsten Gosvig notifications@github.com wrote:

it's not in any of the bin/trace-decoder...tar.gz files did you copy the new files into the install directory?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7XWVA2MAXPVKQ6B2OTRBRURFA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELAS4JA#issuecomment-583085604, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7V6EQ7HODFIULSISH3RBRURFANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

If you take a look at the "$(OBJDIR)/%/build/trace-decoder/trace-decoder/stamp" target in the freedom-tools Makefile, I added the copying of the original artifacts.

It would be really nice if this part was added to a "make install" target in the trace-decoder makefile just like it is done for binutils, gdb, etc., as the trace-decoder should have the knowledge of what to copy.

bradseevers commented 4 years ago

I will take a look at it.

-brad

On Thu, Feb 6, 2020 at 12:14 PM Carsten Gosvig notifications@github.com wrote:

If you take a look at the "$(OBJDIR)/%/build/trace-decoder/trace-decoder/stamp" target in the freedom-tools Makefile, I added the copying of the original artifacts.

It would be really nice if this part was added to a "make install" target in the trace-decoder makefile just like it is done for binutils, gdb, etc., as the trace-decoder should have the knowledge of what to copy.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7RILCMSEGKTN3JMNXLRBRVTXA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELATYDA#issuecomment-583089164, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7XLQKHPO2CKPCZFQ3LRBRVTXANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

That should have been the dqr executable, not the darn executable! Can't type today!

-brad

On Thu, Feb 6, 2020 at 12:07 PM Brad Seevers brad.seevers@sifive.com wrote:

No, I don’t copy the darn executable or the far lis anywhere

On Thu, Feb 6, 2020 at 12:05 PM Carsten Gosvig notifications@github.com wrote:

it's not in any of the bin/trace-decoder...tar.gz files did you copy the new files into the install directory?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7XWVA2MAXPVKQ6B2OTRBRURFA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELAS4JA#issuecomment-583085604, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7V6EQ7HODFIULSISH3RBRURFANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Carsten,

I will add an install target to the trace-decoder makefile if you update the freedom-tools Makefile to use it!

-brad

On Thu, Feb 6, 2020 at 12:14 PM Carsten Gosvig notifications@github.com wrote:

If you take a look at the "$(OBJDIR)/%/build/trace-decoder/trace-decoder/stamp" target in the freedom-tools Makefile, I added the copying of the original artifacts.

It would be really nice if this part was added to a "make install" target in the trace-decoder makefile just like it is done for binutils, gdb, etc., as the trace-decoder should have the knowledge of what to copy.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7RILCMSEGKTN3JMNXLRBRVTXA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELATYDA#issuecomment-583089164, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7XLQKHPO2CKPCZFQ3LRBRVTXANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

Perfect - thanks. Will it be like: make install INSTALLPATH=...

bradseevers commented 4 years ago

Yes, just like that!

-brad

On Thu, Feb 6, 2020 at 1:37 PM Carsten Gosvig notifications@github.com wrote:

Perfect - thanks. Will it be like: make install INSTALLPATH=...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7VPIAOA3KA53JN3PD3RBR7IFA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELA4AJQ#issuecomment-583122982, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7QB43BDHAXHNDKPIE3RBR7IFANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

Good - just let me know when you have update the freedom-tools branch to point to your updated trace-decoder, then I will try it out immediately.