search

sifive / wake

The SiFive wake build tool
Other
86 stars 28 forks source link

File search *.wake crosses submodule boundaries #1137

Open mmjconolly opened 1 year ago

mmjconolly commented 1 year ago

We've traditionally searched all submodules and embededded git repositories for *.wake files rather than just the git repository at the root of the workspace

It could be nice to have a --dont-search-submodules (or whatever) option to be able to prevent submodules from being searched.

We can currently emulate this behaviour somewhat by looking at git's .gitmodules file and then manually transcribing paths into .wakeignore.

Perhaps .wakeroot could become a place for wake to store repository-level options regarding wake, for example

$ cat .wakeroot
minimum_version=0.31.0
dont_search_submodules=true
V-FEXrt commented 1 year ago

Discussed in the meeting. Sounds like we are happy with doing this and making wakeroot a JSON file