sifive / wake

The SiFive wake build tool
Other
86 stars 28 forks source link

rsc: Join chunked futures into single await #1565

Closed V-FEXrt closed 5 months ago

V-FEXrt commented 5 months ago

Joining all the futures before awaiting them gives a small but noticeable performance improvement without much cost to code readability.

Going to move forward with this change and keep a close eye on it. This is something worth deeper profiling later but for now still provides a net win.

V-FEXrt commented 5 months ago

More testing has shown that this increase the variance quite a bit while under heavy load and it was decided that its better to have all jobs finish a little slower than having some jobs finish faster and some jobs finish much slower.

Closing