search

sifive / wake

The SiFive wake build tool
Other
86 stars 28 forks source link

stdlib: Support (de)serialize for unicode strings #1586

Closed V-FEXrt closed 4 months ago

V-FEXrt commented 5 months ago

To fully support unicode strings in the command/environment parts of a job in the RSC we need to fully serialize them. Before this change it wasn't possible to extract the underlying bytes of a unicode string (only the first byte was available). This updates the stdlib to have two functions. One from string to backing bytes and one from bytes to backing string.

No processing should be done on the bytes or it will likely result in an invalid UTF8 string

ag-eitilt commented 4 months ago

Actually, do we have anything in the tests which would cover this?